Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Issue 2804293003: [LargeIconService] Adding URL fallback for the server (Closed)

Created:
3 years, 8 months ago by jkrcal
Modified:
3 years, 8 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LargeIconService] Adding URL fallback for the server This CL fixes the fallback_opts parameter for favicon server once again (after CL 2790113002). BUG=644102 Review-Url: https://codereview.chromium.org/2804293003 Cr-Commit-Position: refs/heads/master@{#462905} Committed: https://chromium.googlesource.com/chromium/src/+/1222984cb4d97e3e51a0d524ca623a18d39d1d4a

Patch Set 1 #

Patch Set 2 : Fix the unit-test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M components/favicon/core/large_icon_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/favicon/core/large_icon_service_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
jkrcal
Peter, could you PTAL?
3 years, 8 months ago (2017-04-07 15:46:44 UTC) #3
pkotwicz
lgtm
3 years, 8 months ago (2017-04-07 17:08:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804293003/20001
3 years, 8 months ago (2017-04-07 17:11:57 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 17:19:11 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1222984cb4d97e3e51a0d524ca62...

Powered by Google App Engine
This is Rietveld 408576698