Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: components/favicon/core/large_icon_service_unittest.cc

Issue 2804293003: [LargeIconService] Adding URL fallback for the server (Closed)
Patch Set: Fix the unit-test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/favicon/core/large_icon_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/large_icon_service_unittest.cc
diff --git a/components/favicon/core/large_icon_service_unittest.cc b/components/favicon/core/large_icon_service_unittest.cc
index 849a185770faf9f3a497b7da9c5cd053866613be..e7f17ffc7613e259aa86a6783cba49f24198b004 100644
--- a/components/favicon/core/large_icon_service_unittest.cc
+++ b/components/favicon/core/large_icon_service_unittest.cc
@@ -131,7 +131,7 @@ class LargeIconServiceTest : public testing::Test {
TEST_F(LargeIconServiceTest, ShouldGetFromGoogleServer) {
const GURL kExpectedServerUrl(
"https://t0.gstatic.com/faviconV2?client=chrome&drop_404_icon=true"
- "&size=64&min_size=42&max_size=128&fallback_opts=TYPE,SIZE"
+ "&size=64&min_size=42&max_size=128&fallback_opts=TYPE,SIZE,URL"
"&url=http://www.example.com/");
EXPECT_CALL(mock_favicon_service_, UnableToDownloadFavicon(_)).Times(0);
@@ -158,7 +158,7 @@ TEST_F(LargeIconServiceTest, ShouldTrimQueryParametersForGoogleServer) {
const GURL kDummyUrlWithQuery("http://www.example.com?foo=1");
const GURL kExpectedServerUrl(
"https://t0.gstatic.com/faviconV2?client=chrome&drop_404_icon=true"
- "&size=64&min_size=42&max_size=128&fallback_opts=TYPE,SIZE"
+ "&size=64&min_size=42&max_size=128&fallback_opts=TYPE,SIZE,URL"
"&url=http://www.example.com/");
EXPECT_CALL(*mock_image_fetcher_,
@@ -197,7 +197,7 @@ TEST_F(LargeIconServiceTest, ShouldReportUnavailableIfFetchFromServerFails) {
const GURL kDummyUrlWithQuery("http://www.example.com?foo=1");
const GURL kExpectedServerUrl(
"https://t0.gstatic.com/faviconV2?client=chrome&drop_404_icon=true"
- "&size=64&min_size=42&max_size=128&fallback_opts=TYPE,SIZE"
+ "&size=64&min_size=42&max_size=128&fallback_opts=TYPE,SIZE,URL"
"&url=http://www.example.com/");
EXPECT_CALL(mock_favicon_service_, SetLastResortFavicons(_, _, _, _, _))
@@ -223,7 +223,7 @@ TEST_F(LargeIconServiceTest, ShoutNotGetFromGoogleServerIfUnavailable) {
mock_favicon_service_,
WasUnableToDownloadFavicon(GURL(
"https://t0.gstatic.com/faviconV2?client=chrome&drop_404_icon=true"
- "&size=64&min_size=42&max_size=128&fallback_opts=TYPE,SIZE"
+ "&size=64&min_size=42&max_size=128&fallback_opts=TYPE,SIZE,URL"
"&url=http://www.example.com/")))
.WillByDefault(Return(true));
« no previous file with comments | « components/favicon/core/large_icon_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698