components/favicon/core/large_icon_service.cc - Issue 2804293003: [LargeIconService] Adding URL fallback for the server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/core/large_icon_service.cc

Issue 2804293003: [LargeIconService] Adding URL fallback for the server (Closed)

Patch Set: Fix the unit-test Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon/core/large_icon_service.cc

diff --git a/components/favicon/core/large_icon_service.cc b/components/favicon/core/large_icon_service.cc

index e44e5c7d8e189a020004a5bed931b19259677702..0153ddf34304ffb213863c0486a01a34ff20a270 100644

--- a/components/favicon/core/large_icon_service.cc

+++ b/components/favicon/core/large_icon_service.cc

@@ -32,7 +32,7 @@ namespace {

const char kGoogleServerV2RequestFormat[] =

"https://t0.gstatic.com/faviconV2?"

"client=chrome&drop_404_icon=true&size=%d&min_size=%d&max_size=%d&"

- "fallback_opts=TYPE,SIZE&url=%s";

+ "fallback_opts=TYPE,SIZE,URL&url=%s";

const int kGoogleServerV2MaxSizeInPixel = 128;

const int kGoogleServerV2DesiredSizeInPixel = 64;

« no previous file with comments | « no previous file | components/favicon/core/large_icon_service_unittest.cc » ('j') | no next file with comments »