Chromium Code Reviews
DescriptionFix a crash after removing button from site settings popup
When the "x" button next to a USB device permission is clicked the
permission is revoked and the button should disappear. Instead of trying
to remove the button from the Views hierarchy (which GridLayout doesn't
seem to notice, causing a crash) this patch just removes visibility from
the button.
BUG=707423
Review-Url: https://codereview.chromium.org/2804883002
Cr-Commit-Position: refs/heads/master@{#462296}
(cherry picked from commit d74f628bb38bb54be59013dc01b13d7abb7b3423)
Review-Url: https://codereview.chromium.org/2804153002 .
Cr-Commit-Position: refs/branch-heads/3029@{#620}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/8058517532b691bcf51b677007749882403b2e7b
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||