Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2804153002: Fix a crash after removing button from site settings popup (Closed)

Created:
3 years, 8 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, tfarina, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix a crash after removing button from site settings popup When the "x" button next to a USB device permission is clicked the permission is revoked and the button should disappear. Instead of trying to remove the button from the Views hierarchy (which GridLayout doesn't seem to notice, causing a crash) this patch just removes visibility from the button. BUG=707423 Review-Url: https://codereview.chromium.org/2804883002 Cr-Commit-Position: refs/heads/master@{#462296} (cherry picked from commit d74f628bb38bb54be59013dc01b13d7abb7b3423) Review-Url: https://codereview.chromium.org/2804153002 . Cr-Commit-Position: refs/branch-heads/3029@{#620} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/8058517532b691bcf51b677007749882403b2e7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/ui/views/website_settings/chosen_object_row.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Reilly Grant (use Gerrit)
3 years, 8 months ago (2017-04-07 01:08:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8058517532b691bcf51b677007749882403b2e7b.

Powered by Google App Engine
This is Rietveld 408576698