Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7255)

Unified Diff: chrome/browser/ui/views/website_settings/chosen_object_row.cc

Issue 2804153002: Fix a crash after removing button from site settings popup (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/website_settings/chosen_object_row.cc
diff --git a/chrome/browser/ui/views/website_settings/chosen_object_row.cc b/chrome/browser/ui/views/website_settings/chosen_object_row.cc
index b655d44da06096b13334a763b874e53056144884..ddf13aa96b150817f8596aae87ba0bcb1e1582c1 100644
--- a/chrome/browser/ui/views/website_settings/chosen_object_row.cc
+++ b/chrome/browser/ui/views/website_settings/chosen_object_row.cc
@@ -74,9 +74,8 @@ void ChosenObjectRow::ButtonPressed(views::Button* sender,
WebsiteSettingsUI::GetChosenObjectIcon(*info_, true);
icon_->SetImage(image.ToImageSkia());
- RemoveChildView(delete_button_);
- delete delete_button_;
- delete_button_ = nullptr;
+ DCHECK(delete_button_->visible());
+ delete_button_->SetVisible(false);
for (ChosenObjectRowObserver& observer : observer_list_)
observer.OnChosenObjectDeleted(*info_);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698