Fix a crash after removing button from site settings popup

Fix a crash after removing button from site settings popup

When the "x" button next to a USB device permission is clicked the
permission is revoked and the button should disappear. Instead of trying
to remove the button from the Views hierarchy (which GridLayout doesn't
seem to notice, causing a crash) this patch just removes visibility from
the button.

BUG=707423
Review-Url: https://codereview.chromium.org/2804883002
Cr-Commit-Position: refs/heads/master@{#462296}
Committed: https://chromium.googlesource.com/chromium/src/+/d74f628bb38bb54be59013dc01b13d7abb7b3423

[Reilly Grant (use Gerrit), 2017-04-05 23:10:07]

reillyg@chromium.org changed reviewers:
+ palmer@chromium.org

[Reilly Grant (use Gerrit), 2017-04-05 23:10:08]

Please take a look.

[palmer, 2017-04-05 23:33:44]

Hmm, shouldn't |RemoveChildView| ensure that the |GridLayout| refreshes itself?
Since it doesn't, is that the real bug?

Just wondering. I don't actually know.

[Reilly Grant (use Gerrit), 2017-04-05 23:39:35]

On 2017/04/05 23:33:44, palmer wrote:
> Hmm, shouldn't |RemoveChildView| ensure that the |GridLayout| refreshes
itself?
> Since it doesn't, is that the real bug?
> 
> Just wondering. I don't actually know.

That is the real bug and I've filed issue 708814 to track it but this fixes the
immediate problem.

[palmer, 2017-04-05 23:44:11]

> That is the real bug and I've filed issue 708814 to track it but this fixes
the immediate problem.

Oh, great. :) LGTM.

[Reilly Grant (use Gerrit), 2017-04-05 23:46:51]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2017-04-05 23:47:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 00:39:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491436011142510, "parent_rev":
"201919d8a8f8351eb79f914d6b88dd0be7cc8821", "commit_rev":
"d74f628bb38bb54be59013dc01b13d7abb7b3423"}

[commit-bot: I haz the power, 2017-04-06 00:40:47]

Description was changed from

==========
Fix a crash after removing button from site settings popup

When the "x" button next to a USB device permission is clicked the
permission is revoked and the button should disappear. Instead of trying
to remove the button from the Views hierarchy (which GridLayout doesn't
seem to notice, causing a crash) this patch just removes visibility from
the button.

BUG=707423
==========

to

==========
Fix a crash after removing button from site settings popup

When the "x" button next to a USB device permission is clicked the
permission is revoked and the button should disappear. Instead of trying
to remove the button from the Views hierarchy (which GridLayout doesn't
seem to notice, causing a crash) this patch just removes visibility from
the button.

BUG=707423

Review-Url: https://codereview.chromium.org/2804883002
Cr-Commit-Position: refs/heads/master@{#462296}
Committed:
https://chromium.googlesource.com/chromium/src/+/d74f628bb38bb54be59013dc01b1...
==========

[commit-bot: I haz the power, 2017-04-06 00:40:49]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d74f628bb38bb54be59013dc01b1...