Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2803483005: Remove lazy evaluation of HTMLTextAreaElement::value. (Closed)

Created:
3 years, 8 months ago by tkent
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove lazy evaluation of HTMLTextAreaElement::value. Remove it for cleaner code, and preparation to fix crbug.com/706370. The lazy evaluation isn't very helpful because children of innerEditor is typically 0 or one Text node and an optional trailing <br>. In such case, innerEditorValue() can just return Text::data(), and it's a cheap operation. BUG=706370 Review-Url: https://codereview.chromium.org/2803483005 Cr-Commit-Position: refs/heads/master@{#461998} Committed: https://chromium.googlesource.com/chromium/src/+/4397adcd1b8e9e667dca4f14bab1453ce146641f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp View 4 chunks +4 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/html/TextControlElement.cpp View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tkent
yosin@, would you review this please?
3 years, 8 months ago (2017-04-05 05:54:38 UTC) #7
yosin_UTC9
lgtm Thanks for simplification!
3 years, 8 months ago (2017-04-05 07:12:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803483005/1
3 years, 8 months ago (2017-04-05 07:13:51 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 07:18:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4397adcd1b8e9e667dca4f14bab1...

Powered by Google App Engine
This is Rietveld 408576698