Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLTextAreaElement.h

Issue 2803483005: Remove lazy evaluation of HTMLTextAreaElement::value. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 71
72 enum WrapMethod { NoWrap, SoftWrap, HardWrap }; 72 enum WrapMethod { NoWrap, SoftWrap, HardWrap };
73 73
74 void didAddUserAgentShadowRoot(ShadowRoot&) override; 74 void didAddUserAgentShadowRoot(ShadowRoot&) override;
75 // FIXME: Author shadows should be allowed 75 // FIXME: Author shadows should be allowed
76 // https://bugs.webkit.org/show_bug.cgi?id=92608 76 // https://bugs.webkit.org/show_bug.cgi?id=92608
77 bool areAuthorShadowsAllowed() const override { return false; } 77 bool areAuthorShadowsAllowed() const override { return false; }
78 78
79 void handleBeforeTextInsertedEvent(BeforeTextInsertedEvent*) const; 79 void handleBeforeTextInsertedEvent(BeforeTextInsertedEvent*) const;
80 static String sanitizeUserInputValue(const String&, unsigned maxLength); 80 static String sanitizeUserInputValue(const String&, unsigned maxLength);
81 void updateValue() const; 81 void updateValue();
82 void setInnerEditorValue(const String&) override;
83 void setNonDirtyValue(const String&); 82 void setNonDirtyValue(const String&);
84 void setValueCommon(const String&, 83 void setValueCommon(const String&,
85 TextFieldEventBehavior, 84 TextFieldEventBehavior,
86 TextControlSetValueSelection); 85 TextControlSetValueSelection);
87 86
88 bool isPlaceholderVisible() const override { return m_isPlaceholderVisible; } 87 bool isPlaceholderVisible() const override { return m_isPlaceholderVisible; }
89 void setPlaceholderVisibility(bool) override; 88 void setPlaceholderVisibility(bool) override;
90 bool supportsPlaceholder() const override { return true; } 89 bool supportsPlaceholder() const override { return true; }
91 void updatePlaceholderText() override; 90 void updatePlaceholderText() override;
92 bool isEmptyValue() const override { return value().isEmpty(); } 91 bool isEmptyValue() const override { return value().isEmpty(); }
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 // If the String* argument is 0, apply this->value(). 140 // If the String* argument is 0, apply this->value().
142 bool valueMissing(const String*) const; 141 bool valueMissing(const String*) const;
143 bool tooLong(const String*, NeedsToCheckDirtyFlag) const; 142 bool tooLong(const String*, NeedsToCheckDirtyFlag) const;
144 bool tooShort(const String*, NeedsToCheckDirtyFlag) const; 143 bool tooShort(const String*, NeedsToCheckDirtyFlag) const;
145 144
146 unsigned m_rows; 145 unsigned m_rows;
147 unsigned m_cols; 146 unsigned m_cols;
148 WrapMethod m_wrap; 147 WrapMethod m_wrap;
149 mutable String m_value; 148 mutable String m_value;
150 mutable bool m_isDirty; 149 mutable bool m_isDirty;
151 bool m_valueIsUpToDate;
152 unsigned m_isPlaceholderVisible : 1; 150 unsigned m_isPlaceholderVisible : 1;
153 String m_suggestedValue; 151 String m_suggestedValue;
154 }; 152 };
155 153
156 } // namespace blink 154 } // namespace blink
157 155
158 #endif // HTMLTextAreaElement_h 156 #endif // HTMLTextAreaElement_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698