Remove lazy evaluation of HTMLTextAreaElement::value.

third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Apple Inc. All rights
  * reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 58 matching lines @@
   }
   return text.length() - crlfCount;
 }
 
 HTMLTextAreaElement::HTMLTextAreaElement(Document& document)
     : TextControlElement(textareaTag, document),
       m_rows(defaultRows),
       m_cols(defaultCols),
       m_wrap(SoftWrap),
       m_isDirty(false),
-      m_valueIsUpToDate(true),
       m_isPlaceholderVisible(false) {}
 
 HTMLTextAreaElement* HTMLTextAreaElement::create(Document& document) {
   HTMLTextAreaElement* textArea = new HTMLTextAreaElement(document);
   textArea->ensureUserAgentShadowRoot();
   return textArea;
 }
 
 void HTMLTextAreaElement::didAddUserAgentShadowRoot(ShadowRoot& root) {
   root.appendChild(TextControlInnerEditorElement::create(document()));
@@ skipping 190 matching lines @@
   Element* innerEditor = innerEditorElement();
   for (Node& node : NodeTraversal::descendantsOf(*innerEditor)) {
     if (node.isTextNode())
       continue;
     DCHECK(isHTMLBRElement(node));
     DCHECK_EQ(&node, innerEditor->lastChild());
   }
 #endif
   addPlaceholderBreakElementIfNecessary();
   setChangedSinceLastFormControlChangeEvent(true);
-  m_valueIsUpToDate = false;
+  updateValue();
   setNeedsValidityCheck();
   setAutofilled(false);
   updatePlaceholderVisibility();
 
   if (!isFocused())
     return;
 
   // When typing in a textarea, childrenChanged is not called, so we need to
   // force the directionality check.
   calculateAndAdjustDirectionality();
@@ skipping 52 matching lines @@
       break;
     }
     if (submissionLength > maxLength)
       break;
   }
   if (i > 0 && U16_IS_LEAD(proposedValue[i - 1]))
     --i;
   return proposedValue.left(i);
 }
 
-void HTMLTextAreaElement::updateValue() const {
-  if (m_valueIsUpToDate)
-    return;
-
+void HTMLTextAreaElement::updateValue() {
   m_value = innerEditorValue();
-  const_cast<HTMLTextAreaElement*>(this)->m_valueIsUpToDate = true;
-  const_cast<HTMLTextAreaElement*>(this)->notifyFormStateChanged();
+  notifyFormStateChanged();
   m_isDirty = true;
-  const_cast<HTMLTextAreaElement*>(this)->updatePlaceholderVisibility();
+  updatePlaceholderVisibility();
 }
 
 String HTMLTextAreaElement::value() const {
-  updateValue();
   return m_value;
 }
 
 void HTMLTextAreaElement::setValue(const String& value,
                                    TextFieldEventBehavior eventBehavior,
                                    TextControlSetValueSelection selection) {
   setValueCommon(value, eventBehavior, selection);
   m_isDirty = true;
 }
 
@@ skipping 50 matching lines @@
     case DispatchNoEvent:
       // We need to update textAsOfLastFormControlChangeEvent for |value| IDL
       // setter without focus because input-assist features use setValue("...",
       // DispatchChangeEvent) without setting focus.
       if (!isFocused())
         setTextAsOfLastFormControlChangeEvent(normalizedValue);
       break;
   }
 }
 
-void HTMLTextAreaElement::setInnerEditorValue(const String& value) {
-  TextControlElement::setInnerEditorValue(value);
-  m_valueIsUpToDate = true;
-}
-
 String HTMLTextAreaElement::defaultValue() const {
   StringBuilder value;
 
   // Since there may be comments, ignore nodes other than text nodes.
   for (Node* n = firstChild(); n; n = n->nextSibling()) {
     if (n->isTextNode())
       value.append(toText(n)->data());
   }
 
   return value.toString();
@@ skipping 176 matching lines @@
     const Element& source) {
   const HTMLTextAreaElement& sourceElement =
       static_cast<const HTMLTextAreaElement&>(source);
   setValueCommon(sourceElement.value(), DispatchNoEvent,
                  TextControlSetValueSelection::kSetSelectionToEnd);
   m_isDirty = sourceElement.m_isDirty;
   TextControlElement::copyNonAttributePropertiesFromElement(source);
 }
 
 }  // namespace blink