Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2802873003: V8 bindings gen: Error if FeaturePolicy and SecureContext together. (Closed)

Created:
3 years, 8 months ago by Matt Giuca
Modified:
3 years, 8 months ago
Reviewers:
haraken, iclelland, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

V8 bindings gen: Error if FeaturePolicy and SecureContext together. This check was previously added for OriginTrialEnabled and SecureContext (r461653). This applies the same check to FeaturePolicy which has the same limitation (i.e., this *should* work but currently generates broken code where FeaturePolicy is totally ignored, and therefore must be a compile-time error for now. BUG=695123 Review-Url: https://codereview.chromium.org/2802873003 Cr-Commit-Position: refs/heads/master@{#462730} Committed: https://chromium.googlesource.com/chromium/src/+/4dbfdb063d396295597734d850b8f41c20aa50f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Source/bindings/scripts/v8_utilities.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Matt Giuca
Follow-up to https://codereview.chromium.org/2780093003 iclelland: Since you requested this update. yukishiino: For OWNERS.
3 years, 8 months ago (2017-04-06 04:35:07 UTC) #4
haraken
LGTM
3 years, 8 months ago (2017-04-06 04:35:59 UTC) #5
Yuki
LGTM.
3 years, 8 months ago (2017-04-06 06:30:08 UTC) #6
iclelland
lgtm
3 years, 8 months ago (2017-04-06 12:55:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802873003/1
3 years, 8 months ago (2017-04-07 01:10:23 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 01:21:54 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4dbfdb063d396295597734d850b8...

Powered by Google App Engine
This is Rietveld 408576698