Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Side by Side Diff: third_party/WebKit/Source/bindings/scripts/v8_utilities.py

Issue 2802873003: V8 bindings gen: Error if FeaturePolicy and SecureContext together. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2013 Google Inc. All rights reserved. 1 # Copyright (C) 2013 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 405 matching lines...) Expand 10 before | Expand all | Expand 10 after
416 trial_name = extended_attributes['OriginTrialEnabled'] 416 trial_name = extended_attributes['OriginTrialEnabled']
417 return 'OriginTrials::%sEnabled' % uncapitalize(trial_name) 417 return 'OriginTrials::%sEnabled' % uncapitalize(trial_name)
418 418
419 is_feature_policy_enabled = 'FeaturePolicy' in extended_attributes 419 is_feature_policy_enabled = 'FeaturePolicy' in extended_attributes
420 420
421 if is_feature_policy_enabled and 'RuntimeEnabled' in extended_attributes: 421 if is_feature_policy_enabled and 'RuntimeEnabled' in extended_attributes:
422 raise Exception('[FeaturePolicy] and [RuntimeEnabled] must ' 422 raise Exception('[FeaturePolicy] and [RuntimeEnabled] must '
423 'not be specified on the same definition: %s' 423 'not be specified on the same definition: %s'
424 % definition_or_member.name) 424 % definition_or_member.name)
425 425
426 if is_feature_policy_enabled and 'SecureContext' in extended_attributes:
427 raise Exception('[FeaturePolicy] and [SecureContext] must '
428 'not be specified on the same definition '
429 '(see https://crbug.com/695123 for workaround): %s'
430 % definition_or_member.name)
431
426 if is_feature_policy_enabled: 432 if is_feature_policy_enabled:
427 includes.add('bindings/core/v8/ScriptState.h') 433 includes.add('bindings/core/v8/ScriptState.h')
428 includes.add('platform/feature_policy/FeaturePolicy.h') 434 includes.add('platform/feature_policy/FeaturePolicy.h')
429 435
430 trial_name = extended_attributes['FeaturePolicy'] 436 trial_name = extended_attributes['FeaturePolicy']
431 return 'FeaturePolicy::%sEnabled' % uncapitalize(trial_name) 437 return 'FeaturePolicy::%sEnabled' % uncapitalize(trial_name)
432 438
433 return None 439 return None
434 440
435 441
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
652 return None 658 return None
653 659
654 660
655 IdlInterface.legacy_caller = property(legacy_caller) 661 IdlInterface.legacy_caller = property(legacy_caller)
656 IdlInterface.indexed_property_getter = property(indexed_property_getter) 662 IdlInterface.indexed_property_getter = property(indexed_property_getter)
657 IdlInterface.indexed_property_setter = property(indexed_property_setter) 663 IdlInterface.indexed_property_setter = property(indexed_property_setter)
658 IdlInterface.indexed_property_deleter = property(indexed_property_deleter) 664 IdlInterface.indexed_property_deleter = property(indexed_property_deleter)
659 IdlInterface.named_property_getter = property(named_property_getter) 665 IdlInterface.named_property_getter = property(named_property_getter)
660 IdlInterface.named_property_setter = property(named_property_setter) 666 IdlInterface.named_property_setter = property(named_property_setter)
661 IdlInterface.named_property_deleter = property(named_property_deleter) 667 IdlInterface.named_property_deleter = property(named_property_deleter)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698