Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_utilities.py

Issue 2802873003: V8 bindings gen: Error if FeaturePolicy and SecureContext together. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/scripts/v8_utilities.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_utilities.py b/third_party/WebKit/Source/bindings/scripts/v8_utilities.py
index 09ad2024f7d027bf135ec94447c2a1cdf56f72a0..dec531fd2a4f8ccfc0605058fffc0d95d09ce3e1 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_utilities.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_utilities.py
@@ -423,6 +423,12 @@ def origin_trial_enabled_function_name(definition_or_member):
'not be specified on the same definition: %s'
% definition_or_member.name)
+ if is_feature_policy_enabled and 'SecureContext' in extended_attributes:
+ raise Exception('[FeaturePolicy] and [SecureContext] must '
+ 'not be specified on the same definition '
+ '(see https://crbug.com/695123 for workaround): %s'
+ % definition_or_member.name)
+
if is_feature_policy_enabled:
includes.add('bindings/core/v8/ScriptState.h')
includes.add('platform/feature_policy/FeaturePolicy.h')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698