Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2802863003: Trigger Copyless Paste metadata parsing (Closed)

Created:
3 years, 8 months ago by wychen
Modified:
3 years, 8 months ago
Reviewers:
Maria, dcheng
CC:
chromium-reviews, agrieve+watch_chromium.org, dproctor
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Trigger Copyless Paste metadata parsing BUG=693650 Review-Url: https://codereview.chromium.org/2802863003 Cr-Commit-Position: refs/heads/master@{#463380} Committed: https://chromium.googlesource.com/chromium/src/+/244727d064719e08f022323fecba95ccac5e69c6

Patch Set 1 #

Total comments: 10

Patch Set 2 : rebase #

Patch Set 3 : use new mojo namespace #

Patch Set 4 : address comments #

Total comments: 4

Patch Set 5 : more spaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
A chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java View 1 2 3 4 1 chunk +49 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_renderer_manifest_overlay.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (12 generated)
wychen
PTAL https://codereview.chromium.org/2802863003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java (right): https://codereview.chromium.org/2802863003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java#newcode1231 chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:1231: private void extractCopylessPasteMetadata(final Tab tab) { This also ...
3 years, 8 months ago (2017-04-05 23:21:03 UTC) #2
wychen
dcheng@, could you take a look at chrome_content_renderer_manifest_overlay.json? Thanks!
3 years, 8 months ago (2017-04-05 23:26:09 UTC) #4
Maria
https://codereview.chromium.org/2802863003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java (right): https://codereview.chromium.org/2802863003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java#newcode1231 chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:1231: private void extractCopylessPasteMetadata(final Tab tab) { I wonder if ...
3 years, 8 months ago (2017-04-07 17:50:19 UTC) #5
wychen
https://codereview.chromium.org/2802863003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java (right): https://codereview.chromium.org/2802863003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java#newcode1231 chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:1231: private void extractCopylessPasteMetadata(final Tab tab) { On 2017/04/07 17:50:19, ...
3 years, 8 months ago (2017-04-07 21:35:02 UTC) #6
wychen
https://codereview.chromium.org/2802863003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java (right): https://codereview.chromium.org/2802863003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java#newcode1231 chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:1231: private void extractCopylessPasteMetadata(final Tab tab) { On 2017/04/07 21:35:01, ...
3 years, 8 months ago (2017-04-07 21:37:32 UTC) #7
Maria
lgtm https://codereview.chromium.org/2802863003/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java File chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java (right): https://codereview.chromium.org/2802863003/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java#newcode22 chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java:22: public static void extractCopylessPasteMetadata(final Tab tab) { nit: ...
3 years, 8 months ago (2017-04-07 22:01:40 UTC) #8
wychen
https://codereview.chromium.org/2802863003/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java File chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java (right): https://codereview.chromium.org/2802863003/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java#newcode22 chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java:22: public static void extractCopylessPasteMetadata(final Tab tab) { On 2017/04/07 ...
3 years, 8 months ago (2017-04-07 22:08:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802863003/80001
3 years, 8 months ago (2017-04-10 10:33:48 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/406643)
3 years, 8 months ago (2017-04-10 10:40:43 UTC) #18
dcheng
rs lgtm for mojo manifest change
3 years, 8 months ago (2017-04-10 19:57:09 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802863003/80001
3 years, 8 months ago (2017-04-10 20:05:18 UTC) #21
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 20:15:58 UTC) #24
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/244727d064719e08f022323fecba...

Powered by Google App Engine
This is Rietveld 408576698