Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2806383004: Call AppIndexingReporter on AsyncTask (Closed)

Created:
3 years, 8 months ago by dproctor
Modified:
3 years, 8 months ago
Reviewers:
wychen
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Call AppIndexingReporter on AsyncTask It doesn't need to run on main thread, and lazy Firebase initialization makes disk read. BUG=

Patch Set 1 #

Patch Set 2 : set upstream #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java View 1 2 chunks +8 lines, -2 lines 2 comments Download

Depends on Patchset:

Messages

Total messages: 4 (2 generated)
wychen
https://codereview.chromium.org/2806383004/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java File chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java (right): https://codereview.chromium.org/2806383004/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java#newcode46 chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java:46: AsyncTask.execute(new Runnable() { Probably makes sense to move AsyncTask ...
3 years, 8 months ago (2017-04-10 23:22:24 UTC) #3
dproctor
3 years, 8 months ago (2017-04-10 23:23:16 UTC) #4
https://codereview.chromium.org/2806383004/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java
(right):

https://codereview.chromium.org/2806383004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/AppIndexingUtil.java:46:
AsyncTask.execute(new Runnable() {
On 2017/04/10 23:22:23, wychen wrote:
> Probably makes sense to move AsyncTask to downstream, since upstream caller
> doesn't "know" the details of the downstream implementation details.

Sure, that makes sense.

Powered by Google App Engine
This is Rietveld 408576698