Add Finch flag for Copyless Paste

Add Finch flag for Copyless Paste

BUG=693650
Review-Url: https://codereview.chromium.org/2706363002
Cr-Commit-Position: refs/heads/master@{#463210}
Committed: https://chromium.googlesource.com/chromium/src/+/2212fe7b24c27576a5c8457b8a266cc62d474423

[wychen, 2017-02-21 23:19:07]

wychen@chromium.org changed reviewers:
+ thakis@chromium.org

[wychen, 2017-02-21 23:19:08]

PTAL

[wychen, 2017-02-22 00:24:42]

Description was changed from

==========
Add Finch flag for Copyless Paste

BUG=693650
==========

to

==========
Add Finch flag for Copyless Paste

BUG=693650
==========

[Nico, 2017-02-22 02:35:45]

https://codereview.chromium.org/2706363002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2706363002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:14803: +        Use structured metadata in
local app indexing to provide better context for other apps.
i know some of these words, but i have no idea what this is supposed to mean.

https://codereview.chromium.org/2706363002/diff/1/chrome/renderer/chrome_cont...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/2706363002/diff/1/chrome/renderer/chrome_cont...
chrome/renderer/chrome_content_renderer_client.cc:544: if
(chrome_observer_.get() && !chrome_observer_->is_incognito_process()) {
instead of

  if (a && b)
    if (c)
      d()

do

  if (a && b && c)
    d()

https://codereview.chromium.org/2706363002/diff/1/chrome/renderer/chrome_cont...
chrome/renderer/chrome_content_renderer_client.cc:546: new
copyless_paste::CopylessPasteAgent(render_frame);
add a "// deletes itself" comment or something like that (yes all the bare news
here don't have that either, but that's confusing as well -- they all look like
leaks)

[wychen, 2017-02-22 23:06:23]

Patchset #2 (id:20001) has been deleted

[wychen, 2017-02-22 23:06:55]

https://codereview.chromium.org/2706363002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2706363002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:14803: +        Use structured metadata in
local app indexing to provide better context for other apps.
On 2017/02/22 02:35:44, Nico wrote:
> i know some of these words, but i have no idea what this is supposed to mean.

Now it should be more user-friendly.

https://codereview.chromium.org/2706363002/diff/1/chrome/renderer/chrome_cont...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/2706363002/diff/1/chrome/renderer/chrome_cont...
chrome/renderer/chrome_content_renderer_client.cc:544: if
(chrome_observer_.get() && !chrome_observer_->is_incognito_process()) {
On 2017/02/22 02:35:44, Nico wrote:
> instead of
> 
>   if (a && b)
>     if (c)
>       d()
> 
> do
> 
>   if (a && b && c)
>     d()

Done.

https://codereview.chromium.org/2706363002/diff/1/chrome/renderer/chrome_cont...
chrome/renderer/chrome_content_renderer_client.cc:546: new
copyless_paste::CopylessPasteAgent(render_frame);
On 2017/02/22 02:35:44, Nico wrote:
> add a "// deletes itself" comment or something like that (yes all the bare
news
> here don't have that either, but that's confusing as well -- they all look
like
> leaks)

Done.

[wychen, 2017-04-05 17:52:32]

Patchset #5 (id:100001) has been deleted

[wychen, 2017-04-05 17:53:12]

The CQ bit was checked by wychen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 17:53:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 19:23:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 19:23:41]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[wychen, 2017-04-05 21:08:44]

The CQ bit was checked by wychen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 21:09:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wychen, 2017-04-05 21:44:35]

wychen@chromium.org changed reviewers:
+ isherman@chromium.org

[wychen, 2017-04-05 21:44:36]

copyless_paste_agent is removed. Could you take another look? Thanks!

isherman@, could you take a look at histogram? Thanks!

[wychen, 2017-04-05 21:44:55]

The CQ bit was checked by wychen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 21:45:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ilya Sherman, 2017-04-05 21:53:50]

histograms.xml lgtm

[commit-bot: I haz the power, 2017-04-05 23:13:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 23:13:16]

Dry run: This issue passed the CQ dry run.

[wychen, 2017-04-07 00:50:10]

Nico, could you take another look? Thanks!

[wychen, 2017-04-07 17:27:31]

wychen@chromium.org changed reviewers:
- thakis@chromium.org

[wychen, 2017-04-07 17:27:55]

wychen@chromium.org changed reviewers:
- isherman@chromium.org

[wychen, 2017-04-07 17:28:22]

wychen@chromium.org changed reviewers:
+ isherman@chromium.org, thakis@chromium.org

[Nico, 2017-04-08 00:34:29]

lgtm

[wychen, 2017-04-10 07:42:50]

The CQ bit was checked by wychen@chromium.org

[commit-bot: I haz the power, 2017-04-10 07:43:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 07:45:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 07:45:15]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[wychen, 2017-04-10 08:41:54]

The CQ bit was checked by wychen@chromium.org

[wychen, 2017-04-10 08:41:54]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2706363002/#ps180001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-10 08:42:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 10:23:39]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1491813714068060,
"parent_rev": "5d7042a87c4f1901ef1ed03d29f3e31e8af1724d", "commit_rev":
"2212fe7b24c27576a5c8457b8a266cc62d474423"}

[commit-bot: I haz the power, 2017-04-10 10:24:29]

Description was changed from

==========
Add Finch flag for Copyless Paste

BUG=693650
==========

to

==========
Add Finch flag for Copyless Paste

BUG=693650

Review-Url: https://codereview.chromium.org/2706363002
Cr-Commit-Position: refs/heads/master@{#463210}
Committed:
https://chromium.googlesource.com/chromium/src/+/2212fe7b24c27576a5c8457b8a26...
==========

[commit-bot: I haz the power, 2017-04-10 10:24:30]

Committed patchset #8 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/2212fe7b24c27576a5c8457b8a26...