Enable side-by-side beta and dev channels.

Enable side-by-side beta and dev channels for Google Chrome.

This change introduces two new side-by-side channels for Google Chrome.
Chrome Beta can be installed via the --chrome-beta installer command
line switch, while Chrome Dev can be installed via the --chrome-dev
switch. Such installs have the following qualities:

- They install in ...\Google\Chrome (Beta,Dev)\Application (both
  per-machine and per-user installs are supported).
- They store their User Data directories in %LOCALAPPDATA%\Google\Chrome
  (Beta,Dev)\User Data.
- They register with Google Update under distinct appguids:
  - Beta: {8237E44A-0054-442C-B6B6-EA0509993955}
  - Dev : {401C381F-E0DE-4B85-8BD8-3F3F14FBDA57}
- Their shortcuts, taskbar, and Start Menu icons are badged with "Beta"
  or "Dev", as appropriate.
- While they will not prompt the user to be made the user's default
  browser, they support being made such via the usual platform UX flows.
- They self self-report as being on the "beta" and "dev" channels in
  user metrics and crash reporting, respectively.

BUG=373987
TEST=The test_installer build step covers general "will it blend"
tests. Manual testing should verify such things as:
- Does chrome://version show that the Executable and Profile paths
  contain "Beta" or "Dev"?
- Does chrome://version show "beta" or "dev" as the channel?
- Do the shortcut and taskbar icons thave the proper badge?
- Can these variations be installed alongside normal "Google Chrome"
  with no interference?

Review-Url: https://codereview.chromium.org/2802713002
Cr-Original-Commit-Position: refs/heads/master@{#466436}
Committed: https://chromium.googlesource.com/chromium/src/+/9897be5cb7fc7de9460c61e94eca2c4e27d99d8d
Review-Url: https://codereview.chromium.org/2802713002
Cr-Commit-Position: refs/heads/master@{#466560}
Committed: https://chromium.googlesource.com/chromium/src/+/7df9336519376dca2df90eb4b1f975723d99fa6c

[grt (UTC plus 2), 2017-04-05 14:13:00]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 14:13:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 15:16:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 15:16:35]

Dry run: This issue passed the CQ dry run.

[grt (UTC plus 2), 2017-04-05 19:40:24]

Description was changed from

==========
Enable side-by-side beta and dev channels.

Install with --chrome-beta or --chrome-dev to get side-by-side installs.

BUG=373987
==========

to

==========
Enable side-by-side beta and dev channels for Google Chrome.

This change introduces two new side-by-side channels for Google Chrome.
Chrome Beta can be installed via the --chrome-beta installer command
line switch, while Chrome Dev can be installed via the --chrome-dev
switch. Such installs have the following qualities:

- They install in ...\Google\Chrome (Beta,Dev)\Application (both
  per-machine and per-user installs are supported).
- They store their User Data directories in %LOCALAPPDATA%\Google\Chrome
  (Beta,Dev)\User Data.
- They register with Google Update under distinct appguids:
  - Beta: {8237E44A-0054-442C-B6B6-EA0509993955}
  - Dev : {401C381F-E0DE-4B85-8BD8-3F3F14FBDA57}
- Their shortcuts, taskbar, and Start Menu icons arebadged with "Beta"
  or "Dev", as appropriate.
- While they will not prompt the user to be made the user's default
  browser, they support being made such via the usual platform UX flows.
- They self self-report as being on the "beta" and "dev" channels in
  user metrics and crash reporting, respectively.

BUG=373987
TEST=The test_installer build step covers general "will it blend"
tests. Manual testing should verify such things as:
- Does chrome://version show that the Executable and Profile paths
contain "Beta" or "Dev"?
- Does chrome://version show "beta" or "dev" as the channel?
- Do the shortcut and taskbar icons thave the proper badge?
- Can these variations be installed alongside normal "Google Chrome"
with no interference?
==========

[grt (UTC plus 2), 2017-04-05 19:40:35]

Patchset #1 (id:1) has been deleted

[grt (UTC plus 2), 2017-04-05 19:43:09]

Description was changed from

==========
Enable side-by-side beta and dev channels for Google Chrome.

This change introduces two new side-by-side channels for Google Chrome.
Chrome Beta can be installed via the --chrome-beta installer command
line switch, while Chrome Dev can be installed via the --chrome-dev
switch. Such installs have the following qualities:

- They install in ...\Google\Chrome (Beta,Dev)\Application (both
  per-machine and per-user installs are supported).
- They store their User Data directories in %LOCALAPPDATA%\Google\Chrome
  (Beta,Dev)\User Data.
- They register with Google Update under distinct appguids:
  - Beta: {8237E44A-0054-442C-B6B6-EA0509993955}
  - Dev : {401C381F-E0DE-4B85-8BD8-3F3F14FBDA57}
- Their shortcuts, taskbar, and Start Menu icons arebadged with "Beta"
  or "Dev", as appropriate.
- While they will not prompt the user to be made the user's default
  browser, they support being made such via the usual platform UX flows.
- They self self-report as being on the "beta" and "dev" channels in
  user metrics and crash reporting, respectively.

BUG=373987
TEST=The test_installer build step covers general "will it blend"
tests. Manual testing should verify such things as:
- Does chrome://version show that the Executable and Profile paths
contain "Beta" or "Dev"?
- Does chrome://version show "beta" or "dev" as the channel?
- Do the shortcut and taskbar icons thave the proper badge?
- Can these variations be installed alongside normal "Google Chrome"
with no interference?
==========

to

==========
Enable side-by-side beta and dev channels for Google Chrome.

This change introduces two new side-by-side channels for Google Chrome.
Chrome Beta can be installed via the --chrome-beta installer command
line switch, while Chrome Dev can be installed via the --chrome-dev
switch. Such installs have the following qualities:

- They install in ...\Google\Chrome (Beta,Dev)\Application (both
  per-machine and per-user installs are supported).
- They store their User Data directories in %LOCALAPPDATA%\Google\Chrome
  (Beta,Dev)\User Data.
- They register with Google Update under distinct appguids:
  - Beta: {8237E44A-0054-442C-B6B6-EA0509993955}
  - Dev : {401C381F-E0DE-4B85-8BD8-3F3F14FBDA57}
- Their shortcuts, taskbar, and Start Menu icons are badged with "Beta"
  or "Dev", as appropriate.
- While they will not prompt the user to be made the user's default
  browser, they support being made such via the usual platform UX flows.
- They self self-report as being on the "beta" and "dev" channels in
  user metrics and crash reporting, respectively.

BUG=373987
TEST=The test_installer build step covers general "will it blend"
tests. Manual testing should verify such things as:
- Does chrome://version show that the Executable and Profile paths
contain "Beta" or "Dev"?
- Does chrome://version show "beta" or "dev" as the channel?
- Do the shortcut and taskbar icons thave the proper badge?
- Can these variations be installed alongside normal "Google Chrome"
with no interference?
==========

[grt (UTC plus 2), 2017-04-05 19:44:16]

Description was changed from

==========
Enable side-by-side beta and dev channels for Google Chrome.

This change introduces two new side-by-side channels for Google Chrome.
Chrome Beta can be installed via the --chrome-beta installer command
line switch, while Chrome Dev can be installed via the --chrome-dev
switch. Such installs have the following qualities:

- They install in ...\Google\Chrome (Beta,Dev)\Application (both
  per-machine and per-user installs are supported).
- They store their User Data directories in %LOCALAPPDATA%\Google\Chrome
  (Beta,Dev)\User Data.
- They register with Google Update under distinct appguids:
  - Beta: {8237E44A-0054-442C-B6B6-EA0509993955}
  - Dev : {401C381F-E0DE-4B85-8BD8-3F3F14FBDA57}
- Their shortcuts, taskbar, and Start Menu icons are badged with "Beta"
  or "Dev", as appropriate.
- While they will not prompt the user to be made the user's default
  browser, they support being made such via the usual platform UX flows.
- They self self-report as being on the "beta" and "dev" channels in
  user metrics and crash reporting, respectively.

BUG=373987
TEST=The test_installer build step covers general "will it blend"
tests. Manual testing should verify such things as:
- Does chrome://version show that the Executable and Profile paths
contain "Beta" or "Dev"?
- Does chrome://version show "beta" or "dev" as the channel?
- Do the shortcut and taskbar icons thave the proper badge?
- Can these variations be installed alongside normal "Google Chrome"
with no interference?
==========

to

==========
Enable side-by-side beta and dev channels for Google Chrome.

This change introduces two new side-by-side channels for Google Chrome.
Chrome Beta can be installed via the --chrome-beta installer command
line switch, while Chrome Dev can be installed via the --chrome-dev
switch. Such installs have the following qualities:

- They install in ...\Google\Chrome (Beta,Dev)\Application (both
  per-machine and per-user installs are supported).
- They store their User Data directories in %LOCALAPPDATA%\Google\Chrome
  (Beta,Dev)\User Data.
- They register with Google Update under distinct appguids:
  - Beta: {8237E44A-0054-442C-B6B6-EA0509993955}
  - Dev : {401C381F-E0DE-4B85-8BD8-3F3F14FBDA57}
- Their shortcuts, taskbar, and Start Menu icons are badged with "Beta"
  or "Dev", as appropriate.
- While they will not prompt the user to be made the user's default
  browser, they support being made such via the usual platform UX flows.
- They self self-report as being on the "beta" and "dev" channels in
  user metrics and crash reporting, respectively.

BUG=373987
TEST=The test_installer build step covers general "will it blend"
tests. Manual testing should verify such things as:
- Does chrome://version show that the Executable and Profile paths
  contain "Beta" or "Dev"?
- Does chrome://version show "beta" or "dev" as the channel?
- Do the shortcut and taskbar icons thave the proper badge?
- Can these variations be installed alongside normal "Google Chrome"
  with no interference?
==========

[grt (UTC plus 2), 2017-04-05 19:50:20]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 19:50:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 20:58:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 20:58:30]

Dry run: This issue passed the CQ dry run.

[robertshield, 2017-04-05 21:29:36]

robertshield@chromium.org changed reviewers:
+ robertshield@chromium.org

[robertshield, 2017-04-05 21:29:37]

third of the way through a first skim to get my bearings, just a couple of
mini-nits-so-far

https://codereview.chromium.org/2802713002/diff/20001/chrome/app/chrome_exe.rc
File chrome/app/chrome_exe.rc (right):

https://codereview.chromium.org/2802713002/diff/20001/chrome/app/chrome_exe.r...
chrome/app/chrome_exe.rc:62: IDR_X005_BETA           ICON                   
"theme\\google_chrome\\win\\chrome_beta.ico"
silly nit: could we shift the resource paths left on these lines a bit to
shorten the line length? I don't see a particular reason to keep them aligned
with this much padding

https://codereview.chromium.org/2802713002/diff/20001/chrome/app/chromium_str...
File chrome/app/chromium_strings.grd (right):

https://codereview.chromium.org/2802713002/diff/20001/chrome/app/chromium_str...
chrome/app/chromium_strings.grd:873: Chromium Apps
Is it ok that all of these have the same name?

https://codereview.chromium.org/2802713002/diff/20001/chrome/common/chrome_ic...
File chrome/common/chrome_icon_resources_win.h (right):

https://codereview.chromium.org/2802713002/diff/20001/chrome/common/chrome_ic...
chrome/common/chrome_icon_resources_win.h:38: kBetaApplicationIndex = 9,
part of me want to re-use the legacy indices which iirc were actually never
used. This is fine too though.

[robertshield, 2017-04-06 14:31:03]

Mucho plumbing, looks great, one question of substance:

https://codereview.chromium.org/2802713002/diff/20001/chrome/install_static/g...
File chrome/install_static/google_chrome_install_modes.cc (right):

https://codereview.chromium.org/2802713002/diff/20001/chrome/install_static/g...
chrome/install_static/google_chrome_install_modes.cc:58: L"Google Chrome Beta", 
                    // A distinct base_app_name.
To make sure I understand how running side-by-side works: 

* this distinct base_app_name is used to create a different default
user_data_dir
* the different default user_data_dir is used by the process singleton to enable
different versions of the browser to run at the same time

Are there combinations of environment state where this will break down (thinking
registry policy or environment variable)? Reading
https://codesearch.chromium.org/chromium/src/chrome/install_static/user_data_...
it looks like there might be, but that state doesn't look like something a user
would get into accidentally.

https://codereview.chromium.org/2802713002/diff/20001/chrome/install_static/i...
File chrome/install_static/install_util_unittest.cc (right):

https://codereview.chromium.org/2802713002/diff/20001/chrome/install_static/i...
chrome/install_static/install_util_unittest.cc:424: static constexpr const
wchar_t* kAppGuids[] = {
could you build this from kInstallModes directly? e.g. 

.. = { kInstallModes[0].app_guid, kInstallModes[1].app_guid, ... };

[grt (UTC plus 2), 2017-04-20 13:51:01]

review comments; omit google strings from chromium grd

[grt (UTC plus 2), 2017-04-20 13:53:05]

Thanks. PTAL.

https://codereview.chromium.org/2802713002/diff/20001/chrome/app/chrome_exe.rc
File chrome/app/chrome_exe.rc (right):

https://codereview.chromium.org/2802713002/diff/20001/chrome/app/chrome_exe.r...
chrome/app/chrome_exe.rc:62: IDR_X005_BETA           ICON                   
"theme\\google_chrome\\win\\chrome_beta.ico"
On 2017/04/05 21:29:37, robertshield wrote:
> silly nit: could we shift the resource paths left on these lines a bit to
> shorten the line length? I don't see a particular reason to keep them aligned
> with this much padding

Yes we can!

https://codereview.chromium.org/2802713002/diff/20001/chrome/app/chromium_str...
File chrome/app/chromium_strings.grd (right):

https://codereview.chromium.org/2802713002/diff/20001/chrome/app/chromium_str...
chrome/app/chromium_strings.grd:873: Chromium Apps
On 2017/04/05 21:29:37, robertshield wrote:
> Is it ok that all of these have the same name? 

SxS/canary, dev, and beta do not exist for Chromium. Historically, we've needed
bogus strings in the chromium .grd file for them anyway. Now, however, I think
it's possible to drop that since the constants won't be used in Chromium builds.
Let me see what I can do about this.

https://codereview.chromium.org/2802713002/diff/20001/chrome/common/chrome_ic...
File chrome/common/chrome_icon_resources_win.h (right):

https://codereview.chromium.org/2802713002/diff/20001/chrome/common/chrome_ic...
chrome/common/chrome_icon_resources_win.h:38: kBetaApplicationIndex = 9,
On 2017/04/05 21:29:37, robertshield wrote:
> part of me want to re-use the legacy indices which iirc were actually never
> used. This is fine too though.

huh. i can't find any record of them being used, either (they were added for
https://crbug.com/12701). i seem to recall there being a teeny tiny trickle of
complaints when the placeholders landed, so i think it's safest to not reuse
them.

https://codereview.chromium.org/2802713002/diff/20001/chrome/install_static/g...
File chrome/install_static/google_chrome_install_modes.cc (right):

https://codereview.chromium.org/2802713002/diff/20001/chrome/install_static/g...
chrome/install_static/google_chrome_install_modes.cc:58: L"Google Chrome Beta", 
                    // A distinct base_app_name.
On 2017/04/06 14:31:02, robertshield wrote:
> To make sure I understand how running side-by-side works: 
> 
> * this distinct base_app_name is used to create a different default
> user_data_dir

The install_suffix is used for that. The base_app_name is for registering as a
browser with Windows.

> * the different default user_data_dir is used by the process singleton to
enable
> different versions of the browser to run at the same time

This is correct.

> Are there combinations of environment state where this will break down
(thinking
> registry policy or environment variable)? Reading
>
https://codesearch.chromium.org/chromium/src/chrome/install_static/user_data_...
> it looks like there might be, but that state doesn't look like something a
user
> would get into accidentally.

I don't think so. The install mode is sniffed from the path of chrome.exe in
GetInstallSuffix
(https://codesearch.chromium.org/chromium/src/chrome/install_static/product_in...).
If chrome.exe is in ...\Chrome Beta\Application, then this mode is picked.
Following that, the default user data dir will be in ...\Chrome Beta\User Data.
The only breakdown would be someone running Beta (for example) and then using
--user-data-dir= to pick a parallel install's dir. You get what you ask for in
that case. :-)

Is there something else you see/are thinking of that I'm missing?

https://codereview.chromium.org/2802713002/diff/20001/chrome/install_static/i...
File chrome/install_static/install_util_unittest.cc (right):

https://codereview.chromium.org/2802713002/diff/20001/chrome/install_static/i...
chrome/install_static/install_util_unittest.cc:424: static constexpr const
wchar_t* kAppGuids[] = {
On 2017/04/06 14:31:03, robertshield wrote:
> could you build this from kInstallModes directly? e.g. 
> 
> .. = { kInstallModes[0].app_guid, kInstallModes[1].app_guid, ... };

I could, but it seems more resilient to accidents if the expected constants are
listed here. Otherwise some cut-n-paste magic could result in the test passing,
but with the wrong guids in use.

[grt (UTC plus 2), 2017-04-20 14:00:05]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 14:00:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 14:12:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 14:12:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[grt (UTC plus 2), 2017-04-20 19:25:53]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 19:26:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 21:39:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 21:39:23]

Dry run: This issue passed the CQ dry run.

[robertshield, 2017-04-21 03:10:11]

https://codereview.chromium.org/2802713002/diff/20001/chrome/install_static/g...
File chrome/install_static/google_chrome_install_modes.cc (right):

https://codereview.chromium.org/2802713002/diff/20001/chrome/install_static/g...
chrome/install_static/google_chrome_install_modes.cc:58: L"Google Chrome Beta", 
                    // A distinct base_app_name.
On 2017/04/20 13:53:04, grt (UTC plus 1) wrote:
> On 2017/04/06 14:31:02, robertshield wrote:
> > To make sure I understand how running side-by-side works: 
> > 
> > * this distinct base_app_name is used to create a different default
> > user_data_dir
> 
> The install_suffix is used for that. The base_app_name is for registering as a
> browser with Windows.
> 
> > * the different default user_data_dir is used by the process singleton to
> enable
> > different versions of the browser to run at the same time
> 
> This is correct.
> 
> > Are there combinations of environment state where this will break down
> (thinking
> > registry policy or environment variable)? Reading
> >
>
https://codesearch.chromium.org/chromium/src/chrome/install_static/user_data_...
> > it looks like there might be, but that state doesn't look like something a
> user
> > would get into accidentally.
> 
> I don't think so. The install mode is sniffed from the path of chrome.exe in
> GetInstallSuffix
>
(https://codesearch.chromium.org/chromium/src/chrome/install_static/product_in...).
> If chrome.exe is in ...\Chrome Beta\Application, then this mode is picked.
> Following that, the default user data dir will be in ...\Chrome Beta\User
Data.
> The only breakdown would be someone running Beta (for example) and then using
> --user-data-dir= to pick a parallel install's dir. You get what you ask for in
> that case. :-)
> 
> Is there something else you see/are thinking of that I'm missing?

Will e.g. beta and dev SxS installs pick up the same values from
https://www.chromium.org/administrators/policy-list-3#UserDataDir ? If so, would
having that policy set make having SxS installs present behave strangely / not
work due to profile incompatibility?

[grt (UTC plus 2), 2017-04-21 09:01:50]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 09:02:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[grt (UTC plus 2), 2017-04-21 09:13:47]

On 2017/04/21 03:10:11, robertshield wrote:
>
https://codereview.chromium.org/2802713002/diff/20001/chrome/install_static/g...
> File chrome/install_static/google_chrome_install_modes.cc (right):
> 
>
https://codereview.chromium.org/2802713002/diff/20001/chrome/install_static/g...
> chrome/install_static/google_chrome_install_modes.cc:58: L"Google Chrome
Beta", 
>                     // A distinct base_app_name.
> On 2017/04/20 13:53:04, grt (UTC plus 1) wrote:
> > On 2017/04/06 14:31:02, robertshield wrote:
> > > To make sure I understand how running side-by-side works: 
> > > 
> > > * this distinct base_app_name is used to create a different default
> > > user_data_dir
> > 
> > The install_suffix is used for that. The base_app_name is for registering as
a
> > browser with Windows.
> > 
> > > * the different default user_data_dir is used by the process singleton to
> > enable
> > > different versions of the browser to run at the same time
> > 
> > This is correct.
> > 
> > > Are there combinations of environment state where this will break down
> > (thinking
> > > registry policy or environment variable)? Reading
> > >
> >
>
https://codesearch.chromium.org/chromium/src/chrome/install_static/user_data_...
> > > it looks like there might be, but that state doesn't look like something a
> > user
> > > would get into accidentally.
> > 
> > I don't think so. The install mode is sniffed from the path of chrome.exe in
> > GetInstallSuffix
> >
>
(https://codesearch.chromium.org/chromium/src/chrome/install_static/product_in...).
> > If chrome.exe is in ...\Chrome Beta\Application, then this mode is picked.
> > Following that, the default user data dir will be in ...\Chrome Beta\User
> Data.
> > The only breakdown would be someone running Beta (for example) and then
using
> > --user-data-dir= to pick a parallel install's dir. You get what you ask for
in
> > that case. :-)
> > 
> > Is there something else you see/are thinking of that I'm missing?
> 
> Will e.g. beta and dev SxS installs pick up the same values from
> https://www.chromium.org/administrators/policy-list-3#UserDataDir ? If so,
would
> having that policy set make having SxS installs present behave strangely / not
> work due to profile incompatibility?

You are correct. Based on https://crbug.com/417357, this is working as-desired.

[commit-bot: I haz the power, 2017-04-21 10:13:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 10:13:37]

Dry run: This issue passed the CQ dry run.

[robertshield, 2017-04-21 12:56:41]

On 2017/04/21 09:13:47, grt (UTC plus 2) wrote:
> On 2017/04/21 03:10:11, robertshield wrote:
> >
>
https://codereview.chromium.org/2802713002/diff/20001/chrome/install_static/g...
> > File chrome/install_static/google_chrome_install_modes.cc (right):
> > 
> >
>
https://codereview.chromium.org/2802713002/diff/20001/chrome/install_static/g...
> > chrome/install_static/google_chrome_install_modes.cc:58: L"Google Chrome
> Beta", 
> >                     // A distinct base_app_name.
> > On 2017/04/20 13:53:04, grt (UTC plus 1) wrote:
> > > On 2017/04/06 14:31:02, robertshield wrote:
> > > > To make sure I understand how running side-by-side works: 
> > > > 
> > > > * this distinct base_app_name is used to create a different default
> > > > user_data_dir
> > > 
> > > The install_suffix is used for that. The base_app_name is for registering
as
> a
> > > browser with Windows.
> > > 
> > > > * the different default user_data_dir is used by the process singleton
to
> > > enable
> > > > different versions of the browser to run at the same time
> > > 
> > > This is correct.
> > > 
> > > > Are there combinations of environment state where this will break down
> > > (thinking
> > > > registry policy or environment variable)? Reading
> > > >
> > >
> >
>
https://codesearch.chromium.org/chromium/src/chrome/install_static/user_data_...
> > > > it looks like there might be, but that state doesn't look like something
a
> > > user
> > > > would get into accidentally.
> > > 
> > > I don't think so. The install mode is sniffed from the path of chrome.exe
in
> > > GetInstallSuffix
> > >
> >
>
(https://codesearch.chromium.org/chromium/src/chrome/install_static/product_in...).
> > > If chrome.exe is in ...\Chrome Beta\Application, then this mode is picked.
> > > Following that, the default user data dir will be in ...\Chrome Beta\User
> > Data.
> > > The only breakdown would be someone running Beta (for example) and then
> using
> > > --user-data-dir= to pick a parallel install's dir. You get what you ask
for
> in
> > > that case. :-)
> > > 
> > > Is there something else you see/are thinking of that I'm missing?
> > 
> > Will e.g. beta and dev SxS installs pick up the same values from
> > https://www.chromium.org/administrators/policy-list-3#UserDataDir ? If so,
> would
> > having that policy set make having SxS installs present behave strangely /
not
> > work due to profile incompatibility?
> 
> You are correct. Based on https://crbug.com/417357, this is working
as-desired.

Ok then, as long as that's the intended behaviour: LGTM

[grt (UTC plus 2), 2017-04-21 19:17:35]

grt@chromium.org changed reviewers:
+ thakis@chromium.org

[grt (UTC plus 2), 2017-04-21 19:17:36]

+thakis for chrome/BUILD.gn and chrome/common OWNERS review

[Nico, 2017-04-21 19:27:18]

lgtm

[grt (UTC plus 2), 2017-04-21 20:31:21]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2017-04-21 20:32:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 20:38:48]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1492806681444670,
"parent_rev": "726fecd251f8e697b3be0f23525a906f230c8ea3", "commit_rev":
"9897be5cb7fc7de9460c61e94eca2c4e27d99d8d"}

[commit-bot: I haz the power, 2017-04-21 20:39:00]

Description was changed from

==========
Enable side-by-side beta and dev channels for Google Chrome.

This change introduces two new side-by-side channels for Google Chrome.
Chrome Beta can be installed via the --chrome-beta installer command
line switch, while Chrome Dev can be installed via the --chrome-dev
switch. Such installs have the following qualities:

- They install in ...\Google\Chrome (Beta,Dev)\Application (both
  per-machine and per-user installs are supported).
- They store their User Data directories in %LOCALAPPDATA%\Google\Chrome
  (Beta,Dev)\User Data.
- They register with Google Update under distinct appguids:
  - Beta: {8237E44A-0054-442C-B6B6-EA0509993955}
  - Dev : {401C381F-E0DE-4B85-8BD8-3F3F14FBDA57}
- Their shortcuts, taskbar, and Start Menu icons are badged with "Beta"
  or "Dev", as appropriate.
- While they will not prompt the user to be made the user's default
  browser, they support being made such via the usual platform UX flows.
- They self self-report as being on the "beta" and "dev" channels in
  user metrics and crash reporting, respectively.

BUG=373987
TEST=The test_installer build step covers general "will it blend"
tests. Manual testing should verify such things as:
- Does chrome://version show that the Executable and Profile paths
  contain "Beta" or "Dev"?
- Does chrome://version show "beta" or "dev" as the channel?
- Do the shortcut and taskbar icons thave the proper badge?
- Can these variations be installed alongside normal "Google Chrome"
  with no interference?
==========

to

==========
Enable side-by-side beta and dev channels for Google Chrome.

This change introduces two new side-by-side channels for Google Chrome.
Chrome Beta can be installed via the --chrome-beta installer command
line switch, while Chrome Dev can be installed via the --chrome-dev
switch. Such installs have the following qualities:

- They install in ...\Google\Chrome (Beta,Dev)\Application (both
  per-machine and per-user installs are supported).
- They store their User Data directories in %LOCALAPPDATA%\Google\Chrome
  (Beta,Dev)\User Data.
- They register with Google Update under distinct appguids:
  - Beta: {8237E44A-0054-442C-B6B6-EA0509993955}
  - Dev : {401C381F-E0DE-4B85-8BD8-3F3F14FBDA57}
- Their shortcuts, taskbar, and Start Menu icons are badged with "Beta"
  or "Dev", as appropriate.
- While they will not prompt the user to be made the user's default
  browser, they support being made such via the usual platform UX flows.
- They self self-report as being on the "beta" and "dev" channels in
  user metrics and crash reporting, respectively.

BUG=373987
TEST=The test_installer build step covers general "will it blend"
tests. Manual testing should verify such things as:
- Does chrome://version show that the Executable and Profile paths
  contain "Beta" or "Dev"?
- Does chrome://version show "beta" or "dev" as the channel?
- Do the shortcut and taskbar icons thave the proper badge?
- Can these variations be installed alongside normal "Google Chrome"
  with no interference?

Review-Url: https://codereview.chromium.org/2802713002
Cr-Commit-Position: refs/heads/master@{#466436}
Committed:
https://chromium.googlesource.com/chromium/src/+/9897be5cb7fc7de9460c61e94eca...
==========

[commit-bot: I haz the power, 2017-04-21 20:39:01]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/9897be5cb7fc7de9460c61e94eca...

[grt (UTC plus 2), 2017-04-22 04:27:21]

A revert of this CL (patchset #5 id:100001) has been created in
https://codereview.chromium.org/2834973002/ by grt@chromium.org.

The reason for reverting is: Continuous builder test failure..

[grt (UTC plus 2), 2017-04-23 07:13:54]

Description was changed from

==========
Enable side-by-side beta and dev channels for Google Chrome.

This change introduces two new side-by-side channels for Google Chrome.
Chrome Beta can be installed via the --chrome-beta installer command
line switch, while Chrome Dev can be installed via the --chrome-dev
switch. Such installs have the following qualities:

- They install in ...\Google\Chrome (Beta,Dev)\Application (both
  per-machine and per-user installs are supported).
- They store their User Data directories in %LOCALAPPDATA%\Google\Chrome
  (Beta,Dev)\User Data.
- They register with Google Update under distinct appguids:
  - Beta: {8237E44A-0054-442C-B6B6-EA0509993955}
  - Dev : {401C381F-E0DE-4B85-8BD8-3F3F14FBDA57}
- Their shortcuts, taskbar, and Start Menu icons are badged with "Beta"
  or "Dev", as appropriate.
- While they will not prompt the user to be made the user's default
  browser, they support being made such via the usual platform UX flows.
- They self self-report as being on the "beta" and "dev" channels in
  user metrics and crash reporting, respectively.

BUG=373987
TEST=The test_installer build step covers general "will it blend"
tests. Manual testing should verify such things as:
- Does chrome://version show that the Executable and Profile paths
  contain "Beta" or "Dev"?
- Does chrome://version show "beta" or "dev" as the channel?
- Do the shortcut and taskbar icons thave the proper badge?
- Can these variations be installed alongside normal "Google Chrome"
  with no interference?

Review-Url: https://codereview.chromium.org/2802713002
Cr-Commit-Position: refs/heads/master@{#466436}
Committed:
https://chromium.googlesource.com/chromium/src/+/9897be5cb7fc7de9460c61e94eca...
==========

to

==========
Enable side-by-side beta and dev channels for Google Chrome.

This change introduces two new side-by-side channels for Google Chrome.
Chrome Beta can be installed via the --chrome-beta installer command
line switch, while Chrome Dev can be installed via the --chrome-dev
switch. Such installs have the following qualities:

- They install in ...\Google\Chrome (Beta,Dev)\Application (both
  per-machine and per-user installs are supported).
- They store their User Data directories in %LOCALAPPDATA%\Google\Chrome
  (Beta,Dev)\User Data.
- They register with Google Update under distinct appguids:
  - Beta: {8237E44A-0054-442C-B6B6-EA0509993955}
  - Dev : {401C381F-E0DE-4B85-8BD8-3F3F14FBDA57}
- Their shortcuts, taskbar, and Start Menu icons are badged with "Beta"
  or "Dev", as appropriate.
- While they will not prompt the user to be made the user's default
  browser, they support being made such via the usual platform UX flows.
- They self self-report as being on the "beta" and "dev" channels in
  user metrics and crash reporting, respectively.

BUG=373987
TEST=The test_installer build step covers general "will it blend"
tests. Manual testing should verify such things as:
- Does chrome://version show that the Executable and Profile paths
  contain "Beta" or "Dev"?
- Does chrome://version show "beta" or "dev" as the channel?
- Do the shortcut and taskbar icons thave the proper badge?
- Can these variations be installed alongside normal "Google Chrome"
  with no interference?

Review-Url: https://codereview.chromium.org/2802713002
Cr-Commit-Position: refs/heads/master@{#466436}
Committed:
https://chromium.googlesource.com/chromium/src/+/9897be5cb7fc7de9460c61e94eca...
==========

[grt (UTC plus 2), 2017-04-23 07:14:12]

Relanding with missing test stanzas. Tests pass locally.

[grt (UTC plus 2), 2017-04-23 07:14:19]

The CQ bit was checked by grt@chromium.org

[grt (UTC plus 2), 2017-04-23 07:14:20]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
robertshield@chromium.org
Link to the patchset: https://codereview.chromium.org/2802713002/#ps120001
(title: "add missing test stanza for reland")

[commit-bot: I haz the power, 2017-04-23 07:14:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-23 08:54:56]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1492931659702700,
"parent_rev": "a71798da135574f5d5f1bd7e9342d58ee111cdb7", "commit_rev":
"7df9336519376dca2df90eb4b1f975723d99fa6c"}

[commit-bot: I haz the power, 2017-04-23 08:55:27]

Description was changed from

==========
Enable side-by-side beta and dev channels for Google Chrome.

This change introduces two new side-by-side channels for Google Chrome.
Chrome Beta can be installed via the --chrome-beta installer command
line switch, while Chrome Dev can be installed via the --chrome-dev
switch. Such installs have the following qualities:

- They install in ...\Google\Chrome (Beta,Dev)\Application (both
  per-machine and per-user installs are supported).
- They store their User Data directories in %LOCALAPPDATA%\Google\Chrome
  (Beta,Dev)\User Data.
- They register with Google Update under distinct appguids:
  - Beta: {8237E44A-0054-442C-B6B6-EA0509993955}
  - Dev : {401C381F-E0DE-4B85-8BD8-3F3F14FBDA57}
- Their shortcuts, taskbar, and Start Menu icons are badged with "Beta"
  or "Dev", as appropriate.
- While they will not prompt the user to be made the user's default
  browser, they support being made such via the usual platform UX flows.
- They self self-report as being on the "beta" and "dev" channels in
  user metrics and crash reporting, respectively.

BUG=373987
TEST=The test_installer build step covers general "will it blend"
tests. Manual testing should verify such things as:
- Does chrome://version show that the Executable and Profile paths
  contain "Beta" or "Dev"?
- Does chrome://version show "beta" or "dev" as the channel?
- Do the shortcut and taskbar icons thave the proper badge?
- Can these variations be installed alongside normal "Google Chrome"
  with no interference?

Review-Url: https://codereview.chromium.org/2802713002
Cr-Commit-Position: refs/heads/master@{#466436}
Committed:
https://chromium.googlesource.com/chromium/src/+/9897be5cb7fc7de9460c61e94eca...
==========

to

==========
Enable side-by-side beta and dev channels for Google Chrome.

This change introduces two new side-by-side channels for Google Chrome.
Chrome Beta can be installed via the --chrome-beta installer command
line switch, while Chrome Dev can be installed via the --chrome-dev
switch. Such installs have the following qualities:

- They install in ...\Google\Chrome (Beta,Dev)\Application (both
  per-machine and per-user installs are supported).
- They store their User Data directories in %LOCALAPPDATA%\Google\Chrome
  (Beta,Dev)\User Data.
- They register with Google Update under distinct appguids:
  - Beta: {8237E44A-0054-442C-B6B6-EA0509993955}
  - Dev : {401C381F-E0DE-4B85-8BD8-3F3F14FBDA57}
- Their shortcuts, taskbar, and Start Menu icons are badged with "Beta"
  or "Dev", as appropriate.
- While they will not prompt the user to be made the user's default
  browser, they support being made such via the usual platform UX flows.
- They self self-report as being on the "beta" and "dev" channels in
  user metrics and crash reporting, respectively.

BUG=373987
TEST=The test_installer build step covers general "will it blend"
tests. Manual testing should verify such things as:
- Does chrome://version show that the Executable and Profile paths
  contain "Beta" or "Dev"?
- Does chrome://version show "beta" or "dev" as the channel?
- Do the shortcut and taskbar icons thave the proper badge?
- Can these variations be installed alongside normal "Google Chrome"
  with no interference?

Review-Url: https://codereview.chromium.org/2802713002
Cr-Original-Commit-Position: refs/heads/master@{#466436}
Committed:
https://chromium.googlesource.com/chromium/src/+/9897be5cb7fc7de9460c61e94eca...
Review-Url: https://codereview.chromium.org/2802713002
Cr-Commit-Position: refs/heads/master@{#466560}
Committed:
https://chromium.googlesource.com/chromium/src/+/7df9336519376dca2df90eb4b1f9...
==========

[commit-bot: I haz the power, 2017-04-23 08:55:29]

Committed patchset #6 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/7df9336519376dca2df90eb4b1f9...