Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 2834973002: Revert of Enable side-by-side beta and dev channels. (Closed)

Created:
3 years, 8 months ago by grt (UTC plus 2)
Modified:
3 years, 8 months ago
Reviewers:
Nico, robertshield
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, srahim+watch_chromium.org, jshin+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable side-by-side beta and dev channels. (patchset #5 id:100001 of https://codereview.chromium.org/2802713002/ ) Reason for revert: Continuous builder test failure. Original issue's description: > Enable side-by-side beta and dev channels for Google Chrome. > > This change introduces two new side-by-side channels for Google Chrome. > Chrome Beta can be installed via the --chrome-beta installer command > line switch, while Chrome Dev can be installed via the --chrome-dev > switch. Such installs have the following qualities: > > - They install in ...\Google\Chrome (Beta,Dev)\Application (both > per-machine and per-user installs are supported). > - They store their User Data directories in %LOCALAPPDATA%\Google\Chrome > (Beta,Dev)\User Data. > - They register with Google Update under distinct appguids: > - Beta: {8237E44A-0054-442C-B6B6-EA0509993955} > - Dev : {401C381F-E0DE-4B85-8BD8-3F3F14FBDA57} > - Their shortcuts, taskbar, and Start Menu icons are badged with "Beta" > or "Dev", as appropriate. > - While they will not prompt the user to be made the user's default > browser, they support being made such via the usual platform UX flows. > - They self self-report as being on the "beta" and "dev" channels in > user metrics and crash reporting, respectively. > > BUG=373987 > TEST=The test_installer build step covers general "will it blend" > tests. Manual testing should verify such things as: > - Does chrome://version show that the Executable and Profile paths > contain "Beta" or "Dev"? > - Does chrome://version show "beta" or "dev" as the channel? > - Do the shortcut and taskbar icons thave the proper badge? > - Can these variations be installed alongside normal "Google Chrome" > with no interference? > > Review-Url: https://codereview.chromium.org/2802713002 > Cr-Commit-Position: refs/heads/master@{#466436} > Committed: https://chromium.googlesource.com/chromium/src/+/9897be5cb7fc7de9460c61e94eca2c4e27d99d8d TBR=robertshield@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=373987 Review-Url: https://codereview.chromium.org/2834973002 Cr-Commit-Position: refs/heads/master@{#466535} Committed: https://chromium.googlesource.com/chromium/src/+/6f56a950ce7a91e149fbce18c3bd672f719dedb3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -726 lines) Patch
M chrome/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/app/chrome_dll.rc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/chrome_dll_resource.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/app/chrome_exe.rc View 2 chunks +11 lines, -13 lines 0 comments Download
M chrome/app/chromium_strings.grd View 3 chunks +6 lines, -21 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 3 chunks +1 line, -27 lines 0 comments Download
M chrome/common/chrome_icon_resources_win.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/install_static/google_chrome_install_modes.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/install_static/google_chrome_install_modes.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M chrome/install_static/install_util_unittest.cc View 6 chunks +3 lines, -21 lines 0 comments Download
M chrome/install_static/product_install_details_unittest.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/installer/mini_installer/appid.h View 1 chunk +2 lines, -9 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/installer/mini_installer/chrome_appid.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/installer/mini_installer/configuration.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/installer/mini_installer/configuration_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/installer/setup/install_unittest.cc View 2 chunks +0 lines, -32 lines 0 comments Download
M chrome/installer/setup/setup_install_details_unittest.cc View 2 chunks +0 lines, -76 lines 0 comments Download
M chrome/installer/util/beacons_unittest.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/installer/util/l10n_string_util_unittest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/installer/util/prebuild/create_string_rc.py View 13 chunks +18 lines, -39 lines 0 comments Download
D chrome/test/mini_installer/config/chrome_beta_installed.prop View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/test/mini_installer/config/chrome_beta_no_pv.prop View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/test/mini_installer/config/chrome_beta_not_installed.prop View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/test/mini_installer/config/chrome_beta_not_inuse.prop View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/test/mini_installer/config/chrome_canary_installed.prop View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/mini_installer/config/chrome_canary_inuse.prop View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/mini_installer/config/chrome_canary_no_pv.prop View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/mini_installer/config/chrome_canary_not_installed.prop View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/mini_installer/config/chrome_canary_not_inuse.prop View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/mini_installer/config/chrome_canary_updated.prop View 1 chunk +1 line, -1 line 0 comments Download
D chrome/test/mini_installer/config/chrome_dev_installed.prop View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/test/mini_installer/config/chrome_dev_no_pv.prop View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/test/mini_installer/config/chrome_dev_not_installed.prop View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/test/mini_installer/config/chrome_dev_not_inuse.prop View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/test/mini_installer/config/config.config View 6 chunks +19 lines, -156 lines 0 comments Download
M chrome/test/mini_installer/mini_installer_test.gni View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/test/mini_installer/test_installer.py View 1 chunk +3 lines, -11 lines 0 comments Download
M chrome/test/mini_installer/variable_expander.py View 6 chunks +7 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
grt (UTC plus 2)
Created Revert of Enable side-by-side beta and dev channels.
3 years, 8 months ago (2017-04-22 04:27:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834973002/1
3 years, 8 months ago (2017-04-22 04:27:26 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-22 04:29:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6f56a950ce7a91e149fbce18c3bd...

Powered by Google App Engine
This is Rietveld 408576698