Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2802693003: include Package proto into Result proto (Closed)

Created:
3 years, 8 months ago by nodir
Modified:
3 years, 7 months ago
Reviewers:
iannucci, martiniss
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

include Package proto into Result proto Kitchen runs recipes using recipe engine and needs to know revisions of recipe dependencies that were used for a run. Export entire contents of recipes.cfg in the new result proto. R=iannucci@chromium.org, martiniss@chromium.org BUG=695485 Review-Url: https://codereview.chromium.org/2802693003 Committed: https://github.com/luci/recipes-py/commit/c7d91ef9861b04e41c6a2381382efd58d111fe19

Patch Set 1 #

Patch Set 2 : comment #

Total comments: 3

Patch Set 3 : rebased and addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -43 lines) Patch
M recipe_engine/loader.py View 1 2 2 chunks +1 line, -1 line 0 comments Download
M recipe_engine/package.py View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M recipe_engine/result.proto View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M recipe_engine/result_pb2.py View 1 2 9 chunks +25 lines, -15 lines 0 comments Download
M recipe_engine/run.py View 1 2 2 chunks +14 lines, -26 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
nodir
PTAL
3 years, 8 months ago (2017-04-05 18:35:46 UTC) #1
iannucci
lgtm https://codereview.chromium.org/2802693003/diff/20001/recipe_engine/loader.py File recipe_engine/loader.py (right): https://codereview.chromium.org/2802693003/diff/20001/recipe_engine/loader.py#newcode178 recipe_engine/loader.py:178: return self.universe.config_file let's not add another undocumented property. ...
3 years, 8 months ago (2017-04-05 19:33:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802693003/40001
3 years, 7 months ago (2017-05-11 22:19:25 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://github.com/luci/recipes-py/commit/c7d91ef9861b04e41c6a2381382efd58d111fe19
3 years, 7 months ago (2017-05-11 22:28:01 UTC) #8
iannucci
3 years, 7 months ago (2017-05-12 00:43:35 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2882563002/ by iannucci@chromium.org.

The reason for reverting is: broke the world:
https://build.chromium.org/p/chromium.infra/builders/infra-continuous-trusty-....

Powered by Google App Engine
This is Rietveld 408576698