Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Side by Side Diff: recipe_engine/result.proto

Issue 2802693003: include Package proto into Result proto (Closed)
Patch Set: rebased and addressed comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « recipe_engine/package.py ('k') | recipe_engine/result_pb2.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 syntax = "proto3"; 1 syntax = "proto3";
2 2
3 package recipe_engine; 3 package recipe_engine;
4 4
5 import "package.proto";
6
5 // The result of a recipe execution. 7 // The result of a recipe execution.
6 message Result { 8 message Result {
7 oneof oneof_result { 9 oneof oneof_result {
8 // The json result of a recipe. Guaranteed to be a JSON 'object' (e.g. 10 // The json result of a recipe. Guaranteed to be a JSON 'object' (e.g.
9 // "{...}") or omitted. 11 // "{...}") or omitted.
10 string json_result = 1; 12 string json_result = 1;
11 13
12 // The cause of the failure of a recipe. 14 // The cause of the failure of a recipe.
13 Failure failure = 2; 15 Failure failure = 2;
14 } 16 }
17
18 // Initial recipe repo's package spec (recipes.cfg).
19 Package recipe_package = 3;
15 } 20 }
16 21
17 message Failure { 22 message Failure {
18 // A reason readable by humans. Printed to the UI, and will be seen by users. 23 // A reason readable by humans. Printed to the UI, and will be seen by users.
19 string human_reason = 1; 24 string human_reason = 1;
20 25
21 // The cause of this failure. 26 // The cause of this failure.
22 oneof failure_type { 27 oneof failure_type {
23 // Step timed out. 28 // Step timed out.
24 Timeout timeout = 2; 29 Timeout timeout = 2;
(...skipping 30 matching lines...) Expand all
55 string step = 1; 60 string step = 1;
56 } 61 }
57 62
58 // A step failed to execute "correctly". Correct generally is indicated by a 63 // A step failed to execute "correctly". Correct generally is indicated by a
59 // return code of 0, but the step can allow for other return codes as well. 64 // return code of 0, but the step can allow for other return codes as well.
60 message StepFailure { 65 message StepFailure {
61 // The step which failed. 66 // The step which failed.
62 string step = 1; 67 string step = 1;
63 } 68 }
64 69
OLDNEW
« no previous file with comments | « recipe_engine/package.py ('k') | recipe_engine/result_pb2.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698