Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: recipe_engine/package.py

Issue 2802693003: include Package proto into Result proto (Closed)
Patch Set: rebased and addressed comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « recipe_engine/loader.py ('k') | recipe_engine/result.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_engine/package.py
diff --git a/recipe_engine/package.py b/recipe_engine/package.py
index e376beb8a35b1501643a485b71807383f7a5ba41..e8d491a5022e2f6f6edde4c0074ec088f8bbcf29 100644
--- a/recipe_engine/package.py
+++ b/recipe_engine/package.py
@@ -280,6 +280,7 @@ class PathRepoSpec(RepoSpec):
"""A RepoSpec implementation that uses a local filesystem path."""
def __init__(self, project_id, path):
+ assert os.path.isabs(path), path
self.project_id = project_id
self.path = path
@@ -611,7 +612,7 @@ class PackageDeps(object):
them.
overrides: if not None, a dictionary of project overrides. Dictionary keys
are the `project_id` field to override, and dictionary values
- are the override path.
+ are the absolute override path.
"""
context = PackageContext.from_package_file(
repo_root, package_file, allow_fetch, deps_path=deps_path)
« no previous file with comments | « recipe_engine/loader.py ('k') | recipe_engine/result.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698