Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 2802533002: Rename DocumentMarker::setActiveMatch() to setIsActiveMatch() (Closed)

Created:
3 years, 8 months ago by rlanday
Modified:
3 years, 8 months ago
Reviewers:
*yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename DocumentMarker::setActiveMatch() to setIsActiveMatch() Suggested by @yosin here: https://codereview.chromium.org/2801483002#msg20 What: Rename DM::setActiveMatch() to setIsActiveMatch() Why: Align with the rename of accessor method activeMatch() to IsActiveMatch() in https://codereview.chromium.org/2789373003 Outcome: Improve readability and code health BUG=707867 Review-Url: https://codereview.chromium.org/2802533002 Cr-Commit-Position: refs/heads/master@{#462198} Committed: https://chromium.googlesource.com/chromium/src/+/81e0a769c432ef75f388feca117cd6fac2a516a4

Patch Set 1 #

Patch Set 2 : Remove dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/core/editing/markers/DocumentMarker.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
rlanday
3 years, 8 months ago (2017-04-05 02:14:26 UTC) #4
Xiaocheng
lgtm
3 years, 8 months ago (2017-04-05 02:24:07 UTC) #6
yosin_UTC9
lgtm for code change Please update description to include: What: Rename DM::setActiveMatch() to setIsActiveMatch() Why: ...
3 years, 8 months ago (2017-04-05 03:58:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802533002/20001
3 years, 8 months ago (2017-04-05 18:39:59 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 20:21:59 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/81e0a769c432ef75f388feca117c...

Powered by Google App Engine
This is Rietveld 408576698