Rename DocumentMarker::activeMatch() to IsActiveMatch()

Rename DocumentMarker::activeMatch() to IsActiveMatch()

What: Rename DocumentMarker::activeMatch() to IsActiveMatch()
Why: Adding "Is" makes it very clear that this is an accessor returning a boolean value, and aligns with other boolean predicates, e.g. isFocused() etc.
Outcome: Improve readability and code health

Suggested by yosin: https://codereview.chromium.org/2801483002#msg20

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2789373003
Cr-Commit-Position: refs/heads/master@{#462190}
Committed: https://chromium.googlesource.com/chromium/src/+/2cfc514b3ee3bc1c29d7e853421fe96fb7a9d7ed

[rlanday, 2017-04-05 02:08:16]

Description was changed from

==========
Rename DocumentMarker::activeMatch() to IsActiveMatch()

Suggested by yosin: https://codereview.chromium.org/2801483002#msg20

BUG=707867
==========

to

==========
Rename DocumentMarker::activeMatch() to IsActiveMatch()

Suggested by yosin: https://codereview.chromium.org/2801483002#msg20

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[rlanday, 2017-04-05 02:08:33]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[rlanday, 2017-04-05 02:08:33]

rlanday@chromium.org changed required reviewers:
+ yosin@chromium.org

[yosin_UTC9, 2017-04-05 02:30:42]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2017-04-05 02:30:43]

lgtm for code change

Please update description to include:
What: Rename DM::activeMatch() to IsActiveMatch()
Why: Bold returning bool value, and align other bool predicate, e.g. isFocused()
etc.
Outcome: Improve readability and code health

[yosin_UTC9, 2017-04-05 02:31:12]

Reference to CL of setActiveMatch() is welcome.

[tkent, 2017-04-05 02:44:09]

lgtm.

With the current Blink coding rule, the first letter should be lower-cased.
However, it's ok to use a upper-cased letter because we'll switch to it in this
quarter.

[rlanday, 2017-04-05 18:09:01]

Description was changed from

==========
Rename DocumentMarker::activeMatch() to IsActiveMatch()

Suggested by yosin: https://codereview.chromium.org/2801483002#msg20

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Rename DocumentMarker::activeMatch() to IsActiveMatch()

What: Rename DocumentMarker::activeMatch() to IsActiveMatch()
Why: Adding "Is" makes it very clear that this is an accessor returning a
boolean value, and aligns with other boolean predicates, e.g. isFocused() etc.
Outcome: Improve readability and code health

Suggested by yosin: https://codereview.chromium.org/2801483002#msg20

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[rlanday, 2017-04-05 18:33:07]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-04-05 18:33:07]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2789373003/#ps20001
(title: "Remove dependency")

[commit-bot: I haz the power, 2017-04-05 18:34:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 20:05:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491417187413000,
"parent_rev": "19329f51423819645c51d444e38b1aa331c3043d", "commit_rev":
"2cfc514b3ee3bc1c29d7e853421fe96fb7a9d7ed"}

[commit-bot: I haz the power, 2017-04-05 20:06:29]

Description was changed from

==========
Rename DocumentMarker::activeMatch() to IsActiveMatch()

What: Rename DocumentMarker::activeMatch() to IsActiveMatch()
Why: Adding "Is" makes it very clear that this is an accessor returning a
boolean value, and aligns with other boolean predicates, e.g. isFocused() etc.
Outcome: Improve readability and code health

Suggested by yosin: https://codereview.chromium.org/2801483002#msg20

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Rename DocumentMarker::activeMatch() to IsActiveMatch()

What: Rename DocumentMarker::activeMatch() to IsActiveMatch()
Why: Adding "Is" makes it very clear that this is an accessor returning a
boolean value, and aligns with other boolean predicates, e.g. isFocused() etc.
Outcome: Improve readability and code health

Suggested by yosin: https://codereview.chromium.org/2801483002#msg20

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2789373003
Cr-Commit-Position: refs/heads/master@{#462190}
Committed:
https://chromium.googlesource.com/chromium/src/+/2cfc514b3ee3bc1c29d7e853421f...
==========

[commit-bot: I haz the power, 2017-04-05 20:06:30]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2cfc514b3ee3bc1c29d7e853421f...