MD Settings: Stop rendering unnecessary iron-collapse instances in cert manager.

MD Settings: Stop rendering unnecessary iron-collapse instances in cert manager.

This reduces the time it takes to render the "Authorities" view of the
certificate manager by 40% (450ms -> 250ms).

BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2802513002
Cr-Commit-Position: refs/heads/master@{#462137}
Committed: https://chromium.googlesource.com/chromium/src/+/7d8a6036276bc6de7800e441f1ffd04b560dbe61

[dpapad, 2017-04-05 00:24:06]

Description was changed from

==========
MD Settings: Stop rendering unnecessary iron-collapse instances in cert manager.

This reduces the time it takes to render the "Authorities" view of the
certificate manager by 40% (450ms -> 250ms).

BUG=597347
==========

to

==========
MD Settings: Stop rendering unnecessary iron-collapse instances in cert manager.

This reduces the time it takes to render the "Authorities" view of the
certificate manager by 40% (450ms -> 250ms).

BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-05 00:24:10]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 00:25:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-04-05 00:36:38]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2017-04-05 00:36:39]

https://codereview.chromium.org/2802513002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/certificate_manager_page/certificate_entry.html
(right):

https://codereview.chromium.org/2802513002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/certificate_manager_page/certificate_entry.html:17:
<template is="dom-if" if="[[expanded_]]">
Moving the dom-if outside the iron-collapse saves about 100+ iron-collapse
elements which used to be rendered when the "Authorities" tab was clicked. Now
each one of them is renedred only if the user requests it.

https://codereview.chromium.org/2802513002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/certificate_manager_page/certificate_entry.html:18:
<iron-collapse opened="[[expanded_]]" no-animation>
We our using no-animation for our iron-collapse, which essentially makes it a
completely unnecessary wrapper around the list-frame div below. We should
probably remove this completely in a follow up CL.

[dpapad, 2017-04-05 00:41:37]

Perf view screenshots, http://imgur.com/a/1jbIJ, see "scripting time"

[commit-bot: I haz the power, 2017-04-05 02:16:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 02:16:24]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-04-05 17:31:32]

lgtm

[dpapad, 2017-04-05 17:38:05]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-04-05 17:38:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 17:49:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491413885000770, "parent_rev":
"896437c68b2efb415258f50b88c3a777c52baa09", "commit_rev":
"7d8a6036276bc6de7800e441f1ffd04b560dbe61"}

[commit-bot: I haz the power, 2017-04-05 17:50:12]

Description was changed from

==========
MD Settings: Stop rendering unnecessary iron-collapse instances in cert manager.

This reduces the time it takes to render the "Authorities" view of the
certificate manager by 40% (450ms -> 250ms).

BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Stop rendering unnecessary iron-collapse instances in cert manager.

This reduces the time it takes to render the "Authorities" view of the
certificate manager by 40% (450ms -> 250ms).

BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2802513002
Cr-Commit-Position: refs/heads/master@{#462137}
Committed:
https://chromium.googlesource.com/chromium/src/+/7d8a6036276bc6de7800e441f1ff...
==========

[commit-bot: I haz the power, 2017-04-05 17:50:13]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7d8a6036276bc6de7800e441f1ff...