Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Side by Side Diff: chrome/browser/resources/settings/certificate_manager_page/certificate_entry.html

Issue 2802513002: MD Settings: Stop rendering unnecessary iron-collapse instances in cert manager. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expa nd_button.html"> 2 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expa nd_button.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html">
4 <link rel="import" href="certificates_browser_proxy.html"> 4 <link rel="import" href="certificates_browser_proxy.html">
5 <link rel="import" href="../settings_shared_css.html"> 5 <link rel="import" href="../settings_shared_css.html">
6 <link rel="import" href="certificate_subentry.html"> 6 <link rel="import" href="certificate_subentry.html">
7 7
8 <dom-module id="settings-certificate-entry"> 8 <dom-module id="settings-certificate-entry">
9 <template> 9 <template>
10 <style include="settings-shared"></style> 10 <style include="settings-shared"></style>
11 <div class="settings-box"> 11 <div class="settings-box">
12 <div class="start">[[model.id]]</div> 12 <div class="start">[[model.id]]</div>
13 <cr-expand-button expanded="{{expanded_}}" 13 <cr-expand-button expanded="{{expanded_}}"
14 alt="$i18n{certificateManagerExpandA11yLabel}"> 14 alt="$i18n{certificateManagerExpandA11yLabel}">
15 </cr-expand-button> 15 </cr-expand-button>
16 </div> 16 </div>
17 <iron-collapse opened="[[expanded_]]" no-animation> 17 <template is="dom-if" if="[[expanded_]]">
dpapad 2017/04/05 00:36:39 Moving the dom-if outside the iron-collapse saves
18 <template is="dom-if" if="[[expanded_]]"> 18 <iron-collapse opened="[[expanded_]]" no-animation>
dpapad 2017/04/05 00:36:39 We our using no-animation for our iron-collapse, w
19 <div class="list-frame"> 19 <div class="list-frame">
20 <template is="dom-repeat" items="[[model.subnodes]]"> 20 <template is="dom-repeat" items="[[model.subnodes]]">
21 <settings-certificate-subentry model="[[item]]" 21 <settings-certificate-subentry model="[[item]]"
22 certificate-type="[[certificateType]]" 22 certificate-type="[[certificateType]]"
23 is-last$="[[isLast_(index, model)]]"> 23 is-last$="[[isLast_(index, model)]]">
24 </settings-certificate-subentry> 24 </settings-certificate-subentry>
25 </template> 25 </template>
26 </div> 26 </div>
27 </template> 27 <iron-collapse>
28 <iron-collapse> 28 </template>
29 </template> 29 </template>
30 <script src="certificate_entry.js"></script> 30 <script src="certificate_entry.js"></script>
31 </dom-module> 31 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698