Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2398)

Unified Diff: chrome/browser/resources/settings/certificate_manager_page/certificate_entry.html

Issue 2802513002: MD Settings: Stop rendering unnecessary iron-collapse instances in cert manager. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/certificate_manager_page/certificate_entry.html
diff --git a/chrome/browser/resources/settings/certificate_manager_page/certificate_entry.html b/chrome/browser/resources/settings/certificate_manager_page/certificate_entry.html
index ee0f93a79cbf96c870bcaf5f17b2b9fe9433c391..31cb15c857e3ed0fd3661c32e829c96ccadc55ab 100644
--- a/chrome/browser/resources/settings/certificate_manager_page/certificate_entry.html
+++ b/chrome/browser/resources/settings/certificate_manager_page/certificate_entry.html
@@ -14,8 +14,8 @@
alt="$i18n{certificateManagerExpandA11yLabel}">
</cr-expand-button>
</div>
- <iron-collapse opened="[[expanded_]]" no-animation>
- <template is="dom-if" if="[[expanded_]]">
+ <template is="dom-if" if="[[expanded_]]">
dpapad 2017/04/05 00:36:39 Moving the dom-if outside the iron-collapse saves
+ <iron-collapse opened="[[expanded_]]" no-animation>
dpapad 2017/04/05 00:36:39 We our using no-animation for our iron-collapse, w
<div class="list-frame">
<template is="dom-repeat" items="[[model.subnodes]]">
<settings-certificate-subentry model="[[item]]"
@@ -24,8 +24,8 @@
</settings-certificate-subentry>
</template>
</div>
- </template>
- <iron-collapse>
+ <iron-collapse>
+ </template>
</template>
<script src="certificate_entry.js"></script>
</dom-module>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698