Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2802363002: Update build files and app delegate for new changes to app support files. (Closed)

Created:
3 years, 8 months ago by nicholss
Modified:
3 years, 8 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, ios-reviews_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update build files and app delegate for new changes to app support files. BUG=652781 Review-Url: https://codereview.chromium.org/2802363002 Cr-Commit-Position: refs/heads/master@{#463305} Committed: https://chromium.googlesource.com/chromium/src/+/ea82f1922f45cb60e3d724f10b2134a309566100

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -371 lines) Patch
M remoting/client/ios/BUILD.gn View 4 chunks +3 lines, -6 lines 0 comments Download
M remoting/client/ios/app/BUILD.gn View 3 chunks +29 lines, -4 lines 0 comments Download
M remoting/client/ios/app/app_delegate.mm View 2 chunks +25 lines, -5 lines 0 comments Download
D remoting/client/ios/app/example_view_controller.h View 1 chunk +0 lines, -32 lines 0 comments Download
D remoting/client/ios/app/example_view_controller.mm View 1 chunk +0 lines, -87 lines 0 comments Download
D remoting/client/ios/app_runtime.h View 1 chunk +0 lines, -67 lines 0 comments Download
D remoting/client/ios/app_runtime.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M remoting/client/ios/bridge/DEPS View 1 chunk +1 line, -1 line 0 comments Download
D remoting/client/ios/host.h View 1 chunk +0 lines, -34 lines 0 comments Download
D remoting/client/ios/host.mm View 1 chunk +0 lines, -80 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
nicholss
PTAL, integrating the previous CLs into the iOS build. Removing some cruft.
3 years, 8 months ago (2017-04-07 21:54:43 UTC) #2
Sergey Ulanov
lgtm
3 years, 8 months ago (2017-04-08 00:04:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802363002/1
3 years, 8 months ago (2017-04-10 15:51:30 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 17:21:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ea82f1922f45cb60e3d724f10b21...

Powered by Google App Engine
This is Rietveld 408576698