Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2802293002: //tools/binary_size: Add object file count to Print() (Closed)

Created:
3 years, 8 months ago by agrieve
Modified:
3 years, 8 months ago
Reviewers:
estevenson
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

//tools/binary_size: Add object file count to Print() Another might-be-useful thing to know is whether the list of object files has changed. The order of files might be useful to capture as well, but it's not clear to me how actionable that is. BUG=681694 Review-Url: https://codereview.chromium.org/2802293002 Cr-Commit-Position: refs/heads/master@{#463257} Committed: https://chromium.googlesource.com/chromium/src/+/8c425270f28666a3fab38db1b6e68f54311990ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -78 lines) Patch
M tools/binary_size/describe.py View 4 chunks +37 lines, -7 lines 0 comments Download
M tools/binary_size/file_format.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/binary_size/integration_test.py View 1 chunk +8 lines, -8 lines 0 comments Download
M tools/binary_size/models.py View 2 chunks +5 lines, -4 lines 0 comments Download
M tools/binary_size/testdata/ActualDiff.golden View 1 chunk +64 lines, -58 lines 0 comments Download
M tools/binary_size/testdata/ConsoleNullDiff.golden View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/binary_size/testdata/SymbolGroupMethods.golden View 4 chunks +8 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (5 generated)
estevenson
lgtm
3 years, 8 months ago (2017-04-10 13:25:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802293002/1
3 years, 8 months ago (2017-04-10 14:15:07 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 14:25:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8c425270f28666a3fab38db1b6e6...

Powered by Google App Engine
This is Rietveld 408576698