Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: tools/binary_size/integration_test.py

Issue 2802293002: //tools/binary_size: Add object file count to Print() (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/binary_size/file_format.py ('k') | tools/binary_size/models.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/integration_test.py
diff --git a/tools/binary_size/integration_test.py b/tools/binary_size/integration_test.py
index 052242ed887867f20e19816b39a6a7e0b311fac1..179d22b3b28166f6cb11746d7da503fec8614ab8 100755
--- a/tools/binary_size/integration_test.py
+++ b/tools/binary_size/integration_test.py
@@ -85,14 +85,14 @@ class IntegrationTest(unittest.TestCase):
@_CompareWithGolden
def test_ActualDiff(self):
- map1 = self._CloneSizeInfo()
- map2 = self._CloneSizeInfo()
- map1.metadata = {"foo": 1, "bar": [1,2,3], "baz": "yes"}
- map2.metadata = {"foo": 1, "bar": [1,3], "baz": "yes"}
- map1.symbols -= map1.symbols[0]
- map2.symbols -= map2.symbols[-1]
- map1.symbols[1].size -= 10
- diff = models.Diff(map1, map2)
+ size_info1 = self._CloneSizeInfo()
+ size_info2 = self._CloneSizeInfo()
+ size_info1.metadata = {"foo": 1, "bar": [1,2,3], "baz": "yes"}
+ size_info2.metadata = {"foo": 1, "bar": [1,3], "baz": "yes"}
+ size_info1.symbols -= size_info1.symbols[:2]
+ size_info2.symbols -= size_info2.symbols[-3:]
+ size_info1.symbols[1].size -= 10
+ diff = models.Diff(size_info1, size_info2)
return describe.GenerateLines(diff, verbose=True)
@_CompareWithGolden
« no previous file with comments | « tools/binary_size/file_format.py ('k') | tools/binary_size/models.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698