Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: tools/binary_size/models.py

Issue 2802293002: //tools/binary_size: Add object file count to Print() (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/binary_size/integration_test.py ('k') | tools/binary_size/testdata/ActualDiff.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/models.py
diff --git a/tools/binary_size/models.py b/tools/binary_size/models.py
index 9a422e96c38fc5e0fa0f5fe73870732c7eb9dbd0..ee0481e992e3773fd32d624a93a426f653bfbe23 100644
--- a/tools/binary_size/models.py
+++ b/tools/binary_size/models.py
@@ -236,10 +236,7 @@ class SymbolGroup(BaseSymbol):
return self._symbols[key]
def __sub__(self, other):
- if other.IsGroup():
- other_ids = set(id(s) for s in other)
- else:
- other_ids = set((id(other),))
+ other_ids = set(id(s) for s in other)
new_symbols = [s for s in self if id(s) not in other_ids]
return self._CreateTransformed(new_symbols, section_name=self.section_name)
@@ -262,6 +259,10 @@ class SymbolGroup(BaseSymbol):
return False
@property
+ def object_path(self):
+ return None
+
+ @property
def source_path(self):
return None
« no previous file with comments | « tools/binary_size/integration_test.py ('k') | tools/binary_size/testdata/ActualDiff.golden » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698