Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2802010: Revert 49594 - Convert page contents grabbing from wide to UTF16. The current... (Closed)

Created:
10 years, 6 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, jam+cc_chromium.org, brettw-cc_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 49594 - Convert page contents grabbing from wide to UTF16. The current code is a bit silly because it would capture it in UTF16, then convert to wide, send it to the browser, then convert it to UTF-8 for FTS. TEST=none BUG=none Review URL: http://codereview.chromium.org/2714012 TBR=brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50159

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -134 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/history_contents_provider_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/history/expire_history_backend_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/history/history.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_backend.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_backend.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/history/history_publisher.h View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/history/history_publisher.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/history/history_querying_unittest.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/history/text_database_manager.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/history/text_database_manager.cc View 5 chunks +7 lines, -13 lines 0 comments Download
M chrome/browser/history/text_database_manager_unittest.cc View 13 chunks +16 lines, -17 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_view_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_manager_unittest.cc View 33 chunks +45 lines, -47 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_view.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/render_view.cc View 6 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
10 years, 6 months ago (2010-06-17 23:05:25 UTC) #1
brettw
10 years, 6 months ago (2010-06-18 04:08:56 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698