Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: chrome/browser/tab_contents/tab_contents.cc

Issue 2802010: Revert 49594 - Convert page contents grabbing from wide to UTF16. The current... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/437/src/
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/tab_contents/tab_contents.h" 5 #include "chrome/browser/tab_contents/tab_contents.h"
6 6
7 #if defined(OS_CHROMEOS) 7 #if defined(OS_CHROMEOS)
8 // For GdkScreen 8 // For GdkScreen
9 #include <gdk/gdk.h> 9 #include <gdk/gdk.h>
10 #endif // defined(OS_CHROMEOS) 10 #endif // defined(OS_CHROMEOS)
(...skipping 1955 matching lines...) Expand 10 before | Expand all | Expand 10 after
1966 const webkit_glue::WebApplicationInfo& info) { 1966 const webkit_glue::WebApplicationInfo& info) {
1967 web_app_info_ = info; 1967 web_app_info_ = info;
1968 1968
1969 if (delegate()) 1969 if (delegate())
1970 delegate()->OnDidGetApplicationInfo(this, page_id); 1970 delegate()->OnDidGetApplicationInfo(this, page_id);
1971 } 1971 }
1972 1972
1973 void TabContents::OnPageContents(const GURL& url, 1973 void TabContents::OnPageContents(const GURL& url,
1974 int renderer_process_id, 1974 int renderer_process_id,
1975 int32 page_id, 1975 int32 page_id,
1976 const string16& contents, 1976 const std::wstring& contents,
1977 const std::string& language) { 1977 const std::string& language) {
1978 // Don't index any https pages. People generally don't want their bank 1978 // Don't index any https pages. People generally don't want their bank
1979 // accounts, etc. indexed on their computer, especially since some of these 1979 // accounts, etc. indexed on their computer, especially since some of these
1980 // things are not marked cachable. 1980 // things are not marked cachable.
1981 // TODO(brettw) we may want to consider more elaborate heuristics such as 1981 // TODO(brettw) we may want to consider more elaborate heuristics such as
1982 // the cachability of the page. We may also want to consider subframes (this 1982 // the cachability of the page. We may also want to consider subframes (this
1983 // test will still index subframes if the subframe is SSL). 1983 // test will still index subframes if the subframe is SSL).
1984 // TODO(zelidrag) bug chromium-os:2808 - figure out if we want to reenable 1984 // TODO(zelidrag) bug chromium-os:2808 - figure out if we want to reenable
1985 // content indexing for chromeos in some future releases. 1985 // content indexing for chromeos in some future releases.
1986 #if !defined(OS_CHROMEOS) 1986 #if !defined(OS_CHROMEOS)
(...skipping 1175 matching lines...) Expand 10 before | Expand all | Expand 10 after
3162 AddInfoBar(new SavePasswordInfoBarDelegate(this, form_to_save)); 3162 AddInfoBar(new SavePasswordInfoBarDelegate(this, form_to_save));
3163 } 3163 }
3164 3164
3165 Profile* TabContents::GetProfileForPasswordManager() { 3165 Profile* TabContents::GetProfileForPasswordManager() {
3166 return profile(); 3166 return profile();
3167 } 3167 }
3168 3168
3169 bool TabContents::DidLastPageLoadEncounterSSLErrors() { 3169 bool TabContents::DidLastPageLoadEncounterSSLErrors() {
3170 return controller().ssl_manager()->ProcessedSSLErrorFromRequest(); 3170 return controller().ssl_manager()->ProcessedSSLErrorFromRequest();
3171 } 3171 }
OLDNEW
« no previous file with comments | « chrome/browser/tab_contents/tab_contents.h ('k') | chrome/browser/translate/translate_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698