Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1725)

Unified Diff: chrome/browser/history/history_querying_unittest.cc

Issue 2802010: Revert 49594 - Convert page contents grabbing from wide to UTF16. The current... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/437/src/
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_publisher.cc ('k') | chrome/browser/history/text_database_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_querying_unittest.cc
===================================================================
--- chrome/browser/history/history_querying_unittest.cc (revision 50158)
+++ chrome/browser/history/history_querying_unittest.cc (working copy)
@@ -7,7 +7,6 @@
#include "base/file_path.h"
#include "base/file_util.h"
#include "base/path_service.h"
-#include "base/utf_string_conversions.h"
#include "chrome/browser/history/history.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -24,25 +23,25 @@
const char* url;
const wchar_t* title;
const int days_ago;
- const char* body;
+ const wchar_t* body;
Time time; // Filled by SetUp.
} test_entries[] = {
// This one is visited super long ago so it will be in a different database
// from the next appearance of it at the end.
- {"http://example.com/", L"Other", 180, "Other"},
+ {"http://example.com/", L"Other", 180, L"Other"},
// These are deliberately added out of chronological order. The history
// service should sort them by visit time when returning query results.
// The correct index sort order is 4 2 3 1 0.
{"http://www.google.com/1", L"Title 1", 10,
- "PAGEONE FOO some body text"},
+ L"PAGEONE FOO some body text"},
{"http://www.google.com/3", L"Title 3", 8,
- "PAGETHREE BAR some hello world for you"},
+ L"PAGETHREE BAR some hello world for you"},
{"http://www.google.com/2", L"Title 2", 9,
- "PAGETWO FOO some more blah blah blah"},
+ L"PAGETWO FOO some more blah blah blah"},
// A more recent visit of the first one.
- {"http://example.com/", L"Other", 6, "Other"},
+ {"http://example.com/", L"Other", 6, L"Other"},
};
// Returns true if the nth result in the given results set matches. It will
@@ -113,7 +112,7 @@
PageTransition::LINK, history::RedirectList(),
false);
history_->SetPageTitle(url, test_entries[i].title);
- history_->SetPageContents(url, UTF8ToUTF16(test_entries[i].body));
+ history_->SetPageContents(url, test_entries[i].body);
}
}
« no previous file with comments | « chrome/browser/history/history_publisher.cc ('k') | chrome/browser/history/text_database_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698