Issue 2714012: Convert page contents grabbing from wide to UTF16. The current code is a bit...

Issue 2714012: Convert page contents grabbing from wide to UTF16. The current code is a bit... (Closed)

Created:
10 years, 6 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews, jam+cc_chromium.org, brettw-cc_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Convert page contents grabbing from wide to UTF16. The current code is a bit silly because it would capture it in UTF16, then convert to wide, send it to the browser, then convert it to UTF-8 for FTS. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49594

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 6

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+129 lines, -116 lines)			Patch
M	chrome/browser/autocomplete/history_contents_provider_unittest.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/history/expire_history_backend_unittest.cc	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/history/history.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/history.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/history_backend.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/history_backend.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/history/history_backend_unittest.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/history/history_publisher.h	View	1	3 chunks	+3 lines, -2 lines	3 comments	Download
M	chrome/browser/history/history_publisher.cc	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/history/history_querying_unittest.cc	View		3 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/browser/history/text_database_manager.h	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/history/text_database_manager.cc	View		5 chunks	+11 lines, -7 lines	2 comments	Download
M	chrome/browser/history/text_database_manager_unittest.cc	View		13 chunks	+17 lines, -16 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_view_host_delegate.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/translate/translate_manager_unittest.cc	View		33 chunks	+47 lines, -45 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/render_view.h	View		1 chunk	+3 lines, -3 lines	1 comment	Download
M	chrome/renderer/render_view.cc	View		6 chunks	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

lg, hooray http://codereview.chromium.org/2714012/diff/18001/19009 File chrome/browser/history/history_publisher.h (right): http://codereview.chromium.org/2714012/diff/18001/19009#newcode1 chrome/browser/history/history_publisher.h:1: // Copyright (c) 2010 The Chromium Authors. ...

10 years, 6 months ago (2010-06-10 21:03:35 UTC) #2

brettw

10 years, 6 months ago (2010-06-11 21:01:03 UTC) #3

http://codereview.chromium.org/2714012/diff/18001/19009
File chrome/browser/history/history_publisher.h (right):

http://codereview.chromium.org/2714012/diff/18001/19009#newcode12
chrome/browser/history/history_publisher.h:12: #include "base/string16.h"
We can't forward declare a string16 since it's actually a typedef to some ugly
STL goop.

http://codereview.chromium.org/2714012/diff/18001/19011
File chrome/browser/history/text_database_manager.cc (right):

http://codereview.chromium.org/2714012/diff/18001/19011#newcode32
chrome/browser/history/text_database_manager.cc:32: // TODO(evanm): other
transformations here?
On 2010/06/10 21:03:35, Nico wrote:
> Should this call the string16 version?

This is currently only used for titles. I'm OK having this very small amount of
duplication for now until we also fix titles.

Expand Messages | Collapse Messages