[DevTools] Remove SDK.SDKObject

[DevTools] Remove SDK.SDKObject

We have a few users of it, which are better to use underlying models.
We also have a log of SDKObject's like classes which do not inherit from SDKObject -
that means this abstraction doesn't really work.

As a bonus, we only inherit from Common.Object when necessary, reducing the overhead.

BUG=none

Review-Url: https://codereview.chromium.org/2801943003
Cr-Commit-Position: refs/heads/master@{#462949}
Committed: https://chromium.googlesource.com/chromium/src/+/91588b92f697f08d822778db08d05886a23c51fe

[dgozman, 2017-04-06 22:13:48]

Description was changed from

==========
[DevTools] Remove SDK.SDKObject

We have a few users of it, which are better to use underlying models.
We also have a log of SDKObject's like classes which do not inherit from
SDKObject -
that means this abstraction doesn't really work.

As a bonus, we only inherit from Common.Object when necessary.

BUG=none
==========

to

==========
[DevTools] Remove SDK.SDKObject

We have a few users of it, which are better to use underlying models.
We also have a log of SDKObject's like classes which do not inherit from
SDKObject -
that means this abstraction doesn't really work.

As a bonus, we only inherit from Common.Object when necessary, reducing the
overhead.

BUG=none
==========

[dgozman, 2017-04-06 22:18:16]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2017-04-06 22:18:18]

Could you please take a look?

[dgozman, 2017-04-06 22:18:22]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 22:19:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 01:38:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 01:38:29]

Dry run: This issue passed the CQ dry run.

[pfeldman, 2017-04-07 18:36:03]

https://codereview.chromium.org/2801943003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js
(right):

https://codereview.chromium.org/2801943003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js:71:
this._target = target;
I don't think it makes sense removing SDKObject without removing this._target.
You are not changing anything with your change. Inheriting from Object is free
(it is lazy) and you only increase the number of lines here.

What might make sense is removing this_target all over the place.

https://codereview.chromium.org/2801943003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js
(right):

https://codereview.chromium.org/2801943003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js:456:
var networkManager = (target && requestId) ? target.model(SDK.NetworkManager) :
null;
ditto

https://codereview.chromium.org/2801943003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
(right):

https://codereview.chromium.org/2801943003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:729:
this._request.networkManager().target(), this._linkifiedInitiatorAnchor);
This is the trickiest to resolve - linkifier is a bit sick.

[pfeldman, 2017-04-07 18:51:34]

lgtm

[dgozman, 2017-04-07 18:55:25]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2017-04-07 18:56:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 19:06:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491591325979590, "parent_rev":
"158cc5cd0ffef904f0449bb4ea59a9f49f049818", "commit_rev":
"91588b92f697f08d822778db08d05886a23c51fe"}

[commit-bot: I haz the power, 2017-04-07 19:07:44]

Description was changed from

==========
[DevTools] Remove SDK.SDKObject

We have a few users of it, which are better to use underlying models.
We also have a log of SDKObject's like classes which do not inherit from
SDKObject -
that means this abstraction doesn't really work.

As a bonus, we only inherit from Common.Object when necessary, reducing the
overhead.

BUG=none
==========

to

==========
[DevTools] Remove SDK.SDKObject

We have a few users of it, which are better to use underlying models.
We also have a log of SDKObject's like classes which do not inherit from
SDKObject -
that means this abstraction doesn't really work.

As a bonus, we only inherit from Common.Object when necessary, reducing the
overhead.

BUG=none

Review-Url: https://codereview.chromium.org/2801943003
Cr-Commit-Position: refs/heads/master@{#462949}
Committed:
https://chromium.googlesource.com/chromium/src/+/91588b92f697f08d822778db08d0...
==========

[commit-bot: I haz the power, 2017-04-07 19:07:45]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/91588b92f697f08d822778db08d0...