Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 2801943003: [DevTools] Remove SDK.SDKObject (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
index 57b80e791eccdd75219373a54cd5af51df6954de..aafd190d2afa70d945695fd623085437c8bb017f 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
@@ -724,8 +724,10 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {
}
dispose() {
- if (this._linkifiedInitiatorAnchor)
- this.parentView().linkifier.disposeAnchor(this._request.target(), this._linkifiedInitiatorAnchor);
+ if (this._linkifiedInitiatorAnchor) {
+ this.parentView().linkifier.disposeAnchor(
+ this._request.networkManager().target(), this._linkifiedInitiatorAnchor);
pfeldman 2017/04/07 18:36:03 This is the trickiest to resolve - linkifier is a
+ }
}
/**
@@ -783,7 +785,7 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {
iconElement.classList.add(this._request.resourceType().name());
cell.appendChild(iconElement);
- cell.createTextChild(this._request.target().decorateLabel(this._request.name()));
+ cell.createTextChild(this._request.networkManager().target().decorateLabel(this._request.name()));
this._appendSubtitle(cell, this._request.path());
cell.title = this._request.url();
}
@@ -875,7 +877,8 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {
case SDK.NetworkRequest.InitiatorType.Script:
if (!this._linkifiedInitiatorAnchor) {
this._linkifiedInitiatorAnchor = this.parentView().linkifier.linkifyScriptLocation(
- request.target(), initiator.scriptId, initiator.url, initiator.lineNumber, initiator.columnNumber);
+ request.networkManager().target(), initiator.scriptId, initiator.url, initiator.lineNumber,
+ initiator.columnNumber);
this._linkifiedInitiatorAnchor.title = '';
}
cell.appendChild(this._linkifiedInitiatorAnchor);

Powered by Google App Engine
This is Rietveld 408576698