Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js

Issue 2801943003: [DevTools] Remove SDK.SDKObject (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
index 45d11b2f83703d93960fda1e430683201842c8f5..4750c082d79e8b4143a10d2c75621c5c25344752 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
@@ -31,20 +31,20 @@
* @implements {Common.ContentProvider}
* @unrestricted
*/
-SDK.NetworkRequest = class extends SDK.SDKObject {
+SDK.NetworkRequest = class extends Common.Object {
/**
+ * @param {!SDK.NetworkManager} networkManager
* @param {!Protocol.Network.RequestId} requestId
- * @param {!SDK.Target} target
* @param {string} url
* @param {string} documentURL
* @param {!Protocol.Page.FrameId} frameId
* @param {!Protocol.Network.LoaderId} loaderId
* @param {?Protocol.Network.Initiator} initiator
*/
- constructor(target, requestId, url, documentURL, frameId, loaderId, initiator) {
- super(target);
+ constructor(networkManager, requestId, url, documentURL, frameId, loaderId, initiator) {
+ super();
- this._networkManager = /** @type {!SDK.NetworkManager} */ (target.model(SDK.NetworkManager));
+ this._networkManager = networkManager;
this._requestId = requestId;
this.setUrl(url);
this._documentURL = documentURL;
@@ -531,7 +531,7 @@ SDK.NetworkRequest = class extends SDK.SDKObject {
} else {
this._path = this._parsedURL.host + this._parsedURL.folderPathComponents;
- var inspectedURL = this.target().inspectedURL().asParsedURL();
+ var inspectedURL = this._networkManager.target().inspectedURL().asParsedURL();
this._path = this._path.trimURL(inspectedURL ? inspectedURL.host : '');
if (this._parsedURL.lastPathComponent || this._parsedURL.queryParams) {
this._name =
@@ -1034,7 +1034,7 @@ SDK.NetworkRequest = class extends SDK.SDKObject {
this._pendingContentCallbacks.length = 0;
delete this._contentRequested;
}
- this.target().networkAgent().getResponseBody(this._requestId, onResourceContent.bind(this));
+ this._networkManager.target().networkAgent().getResponseBody(this._requestId, onResourceContent.bind(this));
}
/**
@@ -1109,7 +1109,7 @@ SDK.NetworkRequest = class extends SDK.SDKObject {
}
replayXHR() {
- this.target().networkAgent().replayXHR(this._requestId);
+ this._networkManager.target().networkAgent().replayXHR(this._requestId);
}
/**

Powered by Google App Engine
This is Rietveld 408576698