Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2801393002: Remove remaining references to SVN. (Closed)

Created:
3 years, 8 months ago by qyearsley
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke, jeffcarp
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove remaining references to SVN. BUG=676012 Review-Url: https://codereview.chromium.org/2801393002 Cr-Commit-Position: refs/heads/master@{#463364} Committed: https://chromium.googlesource.com/chromium/src/+/b9af474c03151485e6fc051804996b996371bc94

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove unnecessary test #

Patch Set 3 : <accidental unrelated patch upload, ignore> #

Patch Set 4 : Remove unnecessary test #

Messages

Total messages: 11 (6 generated)
qyearsley
3 years, 8 months ago (2017-04-10 15:45:47 UTC) #2
Dirk Pranke
lgtm https://codereview.chromium.org/2801393002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/reflection_handler_unittest.py File third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/reflection_handler_unittest.py (right): https://codereview.chromium.org/2801393002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/reflection_handler_unittest.py#newcode100 third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/reflection_handler_unittest.py:100: def test_xml_log_non_ascii(self): We can probably just delete this ...
3 years, 8 months ago (2017-04-10 17:37:26 UTC) #4
jeffcarp
lgtm
3 years, 8 months ago (2017-04-10 18:08:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801393002/60001
3 years, 8 months ago (2017-04-10 18:10:57 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 19:37:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b9af474c03151485e6fc05180499...

Powered by Google App Engine
This is Rietveld 408576698