Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/host.py

Issue 2801393002: Remove remaining references to SVN. (Closed)
Patch Set: Remove unnecessary test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2010 Google Inc. All rights reserved. 1 # Copyright (c) 2010 Google Inc. All rights reserved.
2 # Copyright (c) 2009 Apple Inc. All rights reserved. 2 # Copyright (c) 2009 Apple Inc. All rights reserved.
3 # 3 #
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 # so for now we just pass along the whole Host object. 57 # so for now we just pass along the whole Host object.
58 # FIXME: PortFactory doesn't belong on this Host object if Port is going to have a Host (circular dependency). 58 # FIXME: PortFactory doesn't belong on this Host object if Port is going to have a Host (circular dependency).
59 self.port_factory = PortFactory(self) 59 self.port_factory = PortFactory(self)
60 60
61 self._engage_awesome_locale_hacks() 61 self._engage_awesome_locale_hacks()
62 62
63 self.builders = BuilderList(BUILDERS) 63 self.builders = BuilderList(BUILDERS)
64 64
65 # We call this from the Host constructor, as it's one of the 65 # We call this from the Host constructor, as it's one of the
66 # earliest calls made for all webkitpy-based programs. 66 # earliest calls made for all webkitpy-based programs.
67 # TODO(qyearsley): Remove this in a separate clean-up CL.
67 def _engage_awesome_locale_hacks(self): 68 def _engage_awesome_locale_hacks(self):
68 # To make life easier on our non-English users, we override 69 # To make life easier on our non-English users, we override
69 # the locale environment variables inside webkitpy. 70 # the locale environment variables inside webkitpy.
70 # If we don't do this, programs like SVN will output localized 71 # If we don't do this, programs like SVN will output localized
71 # messages and svn.py will fail to parse them. 72 # messages and svn.py will fail to parse them.
72 # FIXME: We should do these overrides *only* for the subprocesses we kno w need them! 73 # FIXME: We should do these overrides *only* for the subprocesses we kno w need them!
73 # This hack only works in unix environments. 74 # This hack only works in unix environments.
74 self.environ['LANGUAGE'] = 'en' 75 self.environ['LANGUAGE'] = 'en'
75 self.environ['LANG'] = 'en_US.UTF-8' 76 self.environ['LANG'] = 'en_US.UTF-8'
76 self.environ['LC_MESSAGES'] = 'en_US.UTF-8' 77 self.environ['LC_MESSAGES'] = 'en_US.UTF-8'
77 self.environ['LC_ALL'] = '' 78 self.environ['LC_ALL'] = ''
78 79
79 def git(self, path=None): 80 def git(self, path=None):
80 if path: 81 if path:
81 return Git(cwd=path, executive=self.executive, filesystem=self.files ystem) 82 return Git(cwd=path, executive=self.executive, filesystem=self.files ystem)
82 if not self._git: 83 if not self._git:
83 self._git = Git(filesystem=self.filesystem, executive=self.executive ) 84 self._git = Git(filesystem=self.filesystem, executive=self.executive )
84 return self._git 85 return self._git
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698