Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py

Issue 2801393002: Remove remaining references to SVN. (Closed)
Patch Set: Remove unnecessary test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py
index 0e25a32bf15c76a91bdea2ae020871f14369f5ae..fa5a7758c964f6e471a539ed74dc95fdc0c40a99 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py
@@ -87,14 +87,8 @@ class WebKitFinder(object):
Raises an AssertionError if the top dir can't be determined.
"""
- # Note: This code somewhat duplicates the code in
- # git.find_checkout_root(). However, that code only works if the top
- # of the SCM repository also matches the top of the WebKit tree. Some SVN users
- # (the chromium test bots, for example), might only check out subdirectories like
- # Tools/Scripts. This code will also work if there is no SCM system at all.
- # TODO(qyearsley): Remove duplicate code; we're not concerned with SVN users anymore.
- # Also, instead of caching the result with a private instance variable, we can use
- # the memoized decorator.
+ # TODO(qyearsley): This code somewhat duplicates the code in
+ # git.find_checkout_root().
if not self._webkit_base:
self._webkit_base = self._webkit_base
module_path = self._filesystem.abspath(self._filesystem.path_to_module(self.__module__))

Powered by Google App Engine
This is Rietveld 408576698