Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2800923004: Revert of [heap] Remove size specializations in static object visitors. (Closed)

Created:
3 years, 8 months ago by ulan
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Remove size specializations in static object visitors. (patchset #4 id:60001 of https://codereview.chromium.org/2763413007/ ) Reason for revert: Speculative revert due to canary crashes. BUG=chromium:708339, chromium:707790 Original issue's description: > [heap] Remove size specializations in static object visitors. > > Apart from that this patch adds kVisitJSObjectFast for JSObjects that > do not have any unboxed double fields and can be visited without > run-time layout check. > > BUG=chromium:694255 > > Review-Url: https://codereview.chromium.org/2763413007 > Cr-Commit-Position: refs/heads/master@{#44237} > Committed: https://chromium.googlesource.com/v8/v8/+/dbb1cbe3a85d5c5528ce876d905e78d2ab35f00b TBR=mlippautz@chromium.org,hpayer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2800923004 Cr-Commit-Position: refs/heads/master@{#44459} Committed: https://chromium.googlesource.com/v8/v8/+/61df2d90a952066cec6eb20fc0602b5fae749874

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -72 lines) Patch
M src/heap/objects-visiting.h View 8 chunks +109 lines, -12 lines 0 comments Download
M src/heap/objects-visiting.cc View 4 chunks +14 lines, -6 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 2 chunks +21 lines, -15 lines 0 comments Download
M src/heap/scavenger.cc View 1 chunk +12 lines, -13 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-body-descriptors-inl.h View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
ulan
Created Revert of [heap] Remove size specializations in static object visitors.
3 years, 8 months ago (2017-04-06 18:55:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800923004/1
3 years, 8 months ago (2017-04-06 18:55:14 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 19:22:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/61df2d90a952066cec6eb20fc0602b5fae7...

Powered by Google App Engine
This is Rietveld 408576698