Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: src/heap/objects-visiting-inl.h

Issue 2800923004: Revert of [heap] Remove size specializations in static object visitors. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/objects-visiting.cc ('k') | src/heap/scavenger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/objects-visiting-inl.h
diff --git a/src/heap/objects-visiting-inl.h b/src/heap/objects-visiting-inl.h
index adaa774253823e46e84d211fe5e5c39340d068f2..493dce7179c54125f98f614058990679556db2b6 100644
--- a/src/heap/objects-visiting-inl.h
+++ b/src/heap/objects-visiting-inl.h
@@ -95,15 +95,18 @@
table_.Register(kVisitJSRegExp, &JSObjectVisitor::Visit);
- table_.Register(kVisitDataObject, &DataObjectVisitor::Visit);
-
- table_.Register(kVisitJSObjectFast, &JSObjectFastVisitor::Visit);
- table_.Register(kVisitJSObject, &JSObjectVisitor::Visit);
+ table_.template RegisterSpecializations<DataObjectVisitor, kVisitDataObject,
+ kVisitDataObjectGeneric>();
+
+ table_.template RegisterSpecializations<JSObjectVisitor, kVisitJSObject,
+ kVisitJSObjectGeneric>();
// Not using specialized Api object visitor for newspace.
- table_.Register(kVisitJSApiObject, &JSObjectVisitor::Visit);
-
- table_.Register(kVisitStruct, &StructVisitor::Visit);
+ table_.template RegisterSpecializations<JSObjectVisitor, kVisitJSApiObject,
+ kVisitJSApiObjectGeneric>();
+
+ table_.template RegisterSpecializations<StructVisitor, kVisitStruct,
+ kVisitStructGeneric>();
table_.Register(kVisitBytecodeArray, &UnreachableVisitor);
table_.Register(kVisitSharedFunctionInfo, &UnreachableVisitor);
@@ -195,14 +198,17 @@
table_.Register(kVisitTransitionArray, &VisitTransitionArray);
- table_.Register(kVisitDataObject, &DataObjectVisitor::Visit);
-
- table_.Register(kVisitJSObjectFast, &JSObjectFastVisitor::Visit);
- table_.Register(kVisitJSObject, &JSObjectVisitor::Visit);
-
- table_.Register(kVisitJSApiObject, &JSApiObjectVisitor::Visit);
-
- table_.Register(kVisitStruct, &StructObjectVisitor::Visit);
+ table_.template RegisterSpecializations<DataObjectVisitor, kVisitDataObject,
+ kVisitDataObjectGeneric>();
+
+ table_.template RegisterSpecializations<JSObjectVisitor, kVisitJSObject,
+ kVisitJSObjectGeneric>();
+
+ table_.template RegisterSpecializations<JSApiObjectVisitor, kVisitJSApiObject,
+ kVisitJSApiObjectGeneric>();
+
+ table_.template RegisterSpecializations<StructObjectVisitor, kVisitStruct,
+ kVisitStructGeneric>();
}
« no previous file with comments | « src/heap/objects-visiting.cc ('k') | src/heap/scavenger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698