Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2800853003: webkitpy: Unify the exit status codes. (Closed)

Created:
3 years, 8 months ago by mithro
Modified:
3 years, 8 months ago
Reviewers:
qyearsley, mcgreevy
CC:
blink-reviews, chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

webkitpy: Unify the exit status codes. Move the special exit status codes from layout tests into common to allow other things like wpt-import to reuse the constants. Review-Url: https://codereview.chromium.org/2800853003 Cr-Commit-Position: refs/heads/master@{#462818} Committed: https://chromium.googlesource.com/chromium/src/+/145d2c1c93f9f35b80ac22e6dd2cdfcf9cafffe5

Patch Set 1 #

Patch Set 2 : git cl try #

Patch Set 3 : webkitpy: Unify the exit status codes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -88 lines) Patch
A third_party/WebKit/Tools/Scripts/webkitpy/common/exit_codes.py View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py View 6 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py View 1 chunk +0 lines, -31 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py View 4 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test.py View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py View 4 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py View 4 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py View 10 chunks +14 lines, -13 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/wpt-import View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
mithro
Hi qyearsley, We came across the fact that wpt-import was returning the random 130 value ...
3 years, 8 months ago (2017-04-06 02:59:33 UTC) #2
qyearsley
LGTM, thanks!
3 years, 8 months ago (2017-04-06 17:14:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800853003/40001
3 years, 8 months ago (2017-04-07 06:41:43 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 09:25:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/145d2c1c93f9f35b80ac22e6dd2c...

Powered by Google App Engine
This is Rietveld 408576698