Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1352)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

Issue 2800853003: webkitpy: Unify the exit status codes. (Closed)
Patch Set: webkitpy: Unify the exit status codes. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
index 299f11a86ca7e41ed3281f0a513271d91b6c8976..518aaf90db7553f4916488c232ca079b8f92e176 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
@@ -34,39 +34,8 @@ import time
from webkitpy.layout_tests.models import test_expectations
from webkitpy.layout_tests.models import test_failures
-
_log = logging.getLogger(__name__)
-OK_EXIT_STATUS = 0
-
-# This matches what the shell does on POSIX.
-INTERRUPTED_EXIT_STATUS = signal.SIGINT + 128
-
-# POSIX limits status codes to 0-255. Normally run-webkit-tests returns the number
-# of tests that failed. These indicate exceptional conditions triggered by the
-# script itself, so we count backwards from 255 (aka -1) to enumerate them.
-#
-# FIXME: crbug.com/357866. We really shouldn't return the number of failures
-# in the exit code at all.
-EARLY_EXIT_STATUS = 251
-SYS_DEPS_EXIT_STATUS = 252
-NO_TESTS_EXIT_STATUS = 253
-NO_DEVICES_EXIT_STATUS = 254
-UNEXPECTED_ERROR_EXIT_STATUS = 255
-
-ERROR_CODES = (
- INTERRUPTED_EXIT_STATUS,
- EARLY_EXIT_STATUS,
- SYS_DEPS_EXIT_STATUS,
- NO_TESTS_EXIT_STATUS,
- NO_DEVICES_EXIT_STATUS,
- UNEXPECTED_ERROR_EXIT_STATUS,
-)
-
-# In order to avoid colliding with the above codes, we put a ceiling on
-# the value returned by num_regressions
-MAX_FAILURES_EXIT_STATUS = 101
-
class TestRunException(Exception):

Powered by Google App Engine
This is Rietveld 408576698