Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py

Issue 2800853003: webkitpy: Unify the exit status codes. (Closed)
Patch Set: webkitpy: Unify the exit status codes. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 20 matching lines...) Expand all
31 import errno 31 import errno
32 import logging 32 import logging
33 33
34 # The _winreg library is only available on Windows. 34 # The _winreg library is only available on Windows.
35 # https://docs.python.org/2/library/_winreg.html 35 # https://docs.python.org/2/library/_winreg.html
36 try: 36 try:
37 import _winreg # pylint: disable=import-error 37 import _winreg # pylint: disable=import-error
38 except ImportError: 38 except ImportError:
39 _winreg = None # pylint: disable=invalid-name 39 _winreg = None # pylint: disable=invalid-name
40 40
41 from webkitpy.common import exit_codes
41 from webkitpy.layout_tests.breakpad.dump_reader_win import DumpReaderWin 42 from webkitpy.layout_tests.breakpad.dump_reader_win import DumpReaderWin
42 from webkitpy.layout_tests.models import test_run_results 43 from webkitpy.layout_tests.models import test_run_results
43 from webkitpy.layout_tests.port import base 44 from webkitpy.layout_tests.port import base
44 from webkitpy.layout_tests.servers import crash_service 45 from webkitpy.layout_tests.servers import crash_service
45 46
46 47
47 _log = logging.getLogger(__name__) 48 _log = logging.getLogger(__name__)
48 49
49 50
50 class WinPort(base.Port): 51 class WinPort(base.Port):
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 if self.get_option('register_cygwin'): 173 if self.get_option('register_cygwin'):
173 setup_mount = self.path_from_chromium_base('third_party', 'cygwin', 'setup_mount.bat') 174 setup_mount = self.path_from_chromium_base('third_party', 'cygwin', 'setup_mount.bat')
174 self._executive.run_command([setup_mount]) # Paths are all absolute , so this does not require a cwd. 175 self._executive.run_command([setup_mount]) # Paths are all absolute , so this does not require a cwd.
175 return env 176 return env
176 177
177 def check_build(self, needs_http, printer): 178 def check_build(self, needs_http, printer):
178 result = super(WinPort, self).check_build(needs_http, printer) 179 result = super(WinPort, self).check_build(needs_http, printer)
179 180
180 self._crash_service_available = self._check_crash_service_available() 181 self._crash_service_available = self._check_crash_service_available()
181 if not self._crash_service_available: 182 if not self._crash_service_available:
182 result = test_run_results.UNEXPECTED_ERROR_EXIT_STATUS 183 result = exit_codes.UNEXPECTED_ERROR_EXIT_STATUS
183 184
184 if result: 185 if result:
185 _log.error('For complete Windows build requirements, please see:') 186 _log.error('For complete Windows build requirements, please see:')
186 _log.error('') 187 _log.error('')
187 _log.error(' https://chromium.googlesource.com/chromium/src/+/mas ter/docs/windows_build_instructions.md') 188 _log.error(' https://chromium.googlesource.com/chromium/src/+/mas ter/docs/windows_build_instructions.md')
188 return result 189 return result
189 190
190 def operating_system(self): 191 def operating_system(self):
191 return 'win' 192 return 'win'
192 193
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 return result 233 return result
233 234
234 def look_for_new_crash_logs(self, crashed_processes, start_time): 235 def look_for_new_crash_logs(self, crashed_processes, start_time):
235 if self.get_option('disable_breakpad'): 236 if self.get_option('disable_breakpad'):
236 return None 237 return None
237 return self._dump_reader.look_for_new_crash_logs(crashed_processes, star t_time) 238 return self._dump_reader.look_for_new_crash_logs(crashed_processes, star t_time)
238 239
239 def clobber_old_port_specific_results(self): 240 def clobber_old_port_specific_results(self):
240 if not self.get_option('disable_breakpad'): 241 if not self.get_option('disable_breakpad'):
241 self._dump_reader.clobber_old_results() 242 self._dump_reader.clobber_old_results()
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698