android: Mark two binder calls oneway

android: Mark two binder calls oneway

These are the only two (important) calls that do not have a return
value, so can be made oneway. "oneway" is roughly equivalent to being
asynchronous, since binder calls are synchronous by default.

This is like an early test to make sure oneway doesn't cause issues.

BUG=689758
Review-Url: https://codereview.chromium.org/2799683007
Cr-Commit-Position: refs/heads/master@{#462955}
Committed: https://chromium.googlesource.com/chromium/src/+/846fef8c771a4987220e3572c984793cb6162d7e

[boliu, 2017-04-06 17:30:46]

Description was changed from

==========
android: Mark two binder calls oneway

These are the only two (important) calls that do not have a return
value, so can be made oneway. "oneway" is roughly equivalent to being
asynchronous, since binder calls are synchronous by default.

BUG=689758
==========

to

==========
android: Mark two binder calls oneway

These are the only two (important) calls that do not have a return
value, so can be made oneway. "oneway" is roughly equivalent to being
asynchronous, since binder calls are synchronous by default.

This is like an early test to make sure oneway doesn't cause issues.

BUG=689758
==========

[boliu, 2017-04-06 17:31:13]

The CQ bit was checked by boliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 17:33:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2017-04-06 18:46:01]

The CQ bit was unchecked by boliu@chromium.org

[boliu, 2017-04-07 16:11:13]

boliu@chromium.org changed reviewers:
+ palmer@chromium.org

[boliu, 2017-04-07 16:11:13]

ptal

[boliu, 2017-04-07 16:11:20]

The CQ bit was checked by boliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 16:11:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 17:03:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 17:03:51]

Dry run: This issue passed the CQ dry run.

[palmer, 2017-04-07 18:18:51]

https://codereview.chromium.org/2799683007/diff/20001/content/public/android/...
File
content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
(right):

https://codereview.chromium.org/2799683007/diff/20001/content/public/android/...
content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java:106:
connection.crashServiceForTesting();
So it doesn't matter if we verify the crash really happened? Or is it the case
that DeadObjectException wasn't really a good test of that anyway? (I don't know
either way, just wondering.)

[boliu, 2017-04-07 18:29:33]

https://codereview.chromium.org/2799683007/diff/20001/content/public/android/...
File
content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
(right):

https://codereview.chromium.org/2799683007/diff/20001/content/public/android/...
content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java:106:
connection.crashServiceForTesting();
On 2017/04/07 18:18:51, palmer wrote:
> So it doesn't matter if we verify the crash really happened? Or is it the case
> that DeadObjectException wasn't really a good test of that anyway? (I don't
know
> either way, just wondering.)

DeadObjectException wasn't a good test. Yes it indicates the other side is gone,
but we don't do anything with it. We listen to asynchronous
onServiceDisconnected to respond to child process going away (crash or normal
shutdown). Test already has to wait for onServiceDisconnected to happen.

[palmer, 2017-04-07 19:03:59]

OK, LGTM then. Thanks!

[boliu, 2017-04-07 19:05:12]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2017-04-07 19:06:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 19:20:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491591912793620,
"parent_rev": "a9afc02163b48dbb93c9a343630096b8f45aec71", "commit_rev":
"846fef8c771a4987220e3572c984793cb6162d7e"}

[commit-bot: I haz the power, 2017-04-07 19:21:43]

Description was changed from

==========
android: Mark two binder calls oneway

These are the only two (important) calls that do not have a return
value, so can be made oneway. "oneway" is roughly equivalent to being
asynchronous, since binder calls are synchronous by default.

This is like an early test to make sure oneway doesn't cause issues.

BUG=689758
==========

to

==========
android: Mark two binder calls oneway

These are the only two (important) calls that do not have a return
value, so can be made oneway. "oneway" is roughly equivalent to being
asynchronous, since binder calls are synchronous by default.

This is like an early test to make sure oneway doesn't cause issues.

BUG=689758

Review-Url: https://codereview.chromium.org/2799683007
Cr-Commit-Position: refs/heads/master@{#462955}
Committed:
https://chromium.googlesource.com/chromium/src/+/846fef8c771a4987220e3572c984...
==========

[commit-bot: I haz the power, 2017-04-07 19:21:45]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/846fef8c771a4987220e3572c984...