content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java - Issue 2799683007: android: Mark two binder calls oneway

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

Issue 2799683007: android: Mark two binder calls oneway (Closed)

Patch Set: fix test Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/android/java/src/org/chromium/base/process_launcher/IChildProcessService.aidl ('k') | content/public/android/java/src/org/chromium/content/common/IGpuProcessCallback.aidl » ('j') | content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

index 4499622fe29b6a53d96e8c3e224efb57e03f4a94..2ad7b8aeb369b0d06f63816d03cd423df204ecc1 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

@@ -12,7 +12,6 @@ import android.content.pm.PackageManager;

import android.content.pm.ServiceInfo;

import android.os.Build;

import android.os.Bundle;

-import android.os.DeadObjectException;

import android.os.IBinder;

import android.os.RemoteException;

@@ -541,13 +540,8 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {

}

@VisibleForTesting

- public boolean crashServiceForTesting() throws RemoteException {

- try {

- mService.crashIntentionallyForTesting();

- } catch (DeadObjectException e) {

- return true;

- }

- return false;

+ public void crashServiceForTesting() throws RemoteException {

+ mService.crashIntentionallyForTesting();

}

@VisibleForTesting