Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1379)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java

Issue 2799683007: android: Mark two binder calls oneway (Closed)
Patch Set: fix test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/android/java/src/org/chromium/content/common/IGpuProcessCallback.aidl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java b/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
index 4de2bfa95f750c1c844af50404aa56c39a59090c..7e08d1ea0d8179ed27747d12859b198cd54960c9 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
@@ -103,7 +103,7 @@ public class ChildProcessLauncherTest extends InstrumentationTestCase {
assertEquals(0, ChildProcessLauncher.connectedServicesCountForTesting());
// Crash the service.
- assertTrue(connection.crashServiceForTesting());
+ connection.crashServiceForTesting();
palmer 2017/04/07 18:18:51 So it doesn't matter if we verify the crash really
boliu 2017/04/07 18:29:33 DeadObjectException wasn't a good test. Yes it ind
// Verify that the connection gets cleaned-up.
CriteriaHelper.pollInstrumentationThread(Criteria.equals(0, new Callable<Integer>() {
@@ -153,7 +153,7 @@ public class ChildProcessLauncherTest extends InstrumentationTestCase {
});
// Crash the service.
- assertTrue(connection.crashServiceForTesting());
+ connection.crashServiceForTesting();
// Verify that the connection gets cleaned-up.
CriteriaHelper.pollInstrumentationThread(Criteria.equals(0, new Callable<Integer>() {
@@ -217,7 +217,7 @@ public class ChildProcessLauncherTest extends InstrumentationTestCase {
});
// Crash the service.
- assertTrue(connection.crashServiceForTesting());
+ connection.crashServiceForTesting();
// Verify that a new service is started for the pending spawn.
CriteriaHelper.pollInstrumentationThread(Criteria.equals(0, new Callable<Integer>() {
« no previous file with comments | « content/public/android/java/src/org/chromium/content/common/IGpuProcessCallback.aidl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698