chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js - Issue 2799563003: MD Settings: Move browserProxies outside of Polymer "properties".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js

Issue 2799563003: MD Settings: Move browserProxies outside of Polymer "properties". (Closed)

Patch Set: Address comment. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/on_startup_page/startup_urls_page.js ('k') | chrome/browser/resources/settings/site_settings/site_data_details_subpage.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js

diff --git a/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js b/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js

index 30600fd96666937fe7fc7f65daa2f21f9e3c2ab1..25a90f060051c48cfaba167bf440cb639275ee63 100644

--- a/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js

+++ b/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js

@@ -12,11 +12,11 @@ Polymer({

properties: {

/** @type {!SearchEngine} */

engine: Object,

- /** @private {!settings.ExtensionControlBrowserProxy} */

- browserProxy_: Object,

+ /** @private {?settings.ExtensionControlBrowserProxy} */

+ browserProxy_: null,

/** @override */

created: function() {

this.browserProxy_ =