Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: chrome/browser/resources/settings/on_startup_page/startup_urls_page.js

Issue 2799563003: MD Settings: Move browserProxies outside of Polymer "properties". (Closed)
Patch Set: Address comment. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
diff --git a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
index e89623beef41cc6eeb572a35bb7cdd0649748c49..c17ed77f63265a3f726178b039968b9c8a5a72f1 100644
--- a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
+++ b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
@@ -15,9 +15,6 @@ Polymer({
properties: {
prefs: Object,
- /** @type {settings.StartupUrlsPageBrowserProxy} */
- browserProxy_: Object,
-
/**
* Pages to load upon browser startup.
* @private {!Array<!StartupPageInfo>}
@@ -34,6 +31,9 @@ Polymer({
lastFocused_: Object,
},
+ /** @private {?settings.StartupUrlsPageBrowserProxy} */
+ browserProxy_: null,
+
/**
* The element to return focus to, when the startup-url-dialog is closed.
* @private {?HTMLElement}

Powered by Google App Engine
This is Rietveld 408576698