Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2799443002: Implemented ARIA colindex, rowindex, colcount and rowcount for Chromevox. (Closed)

Created:
3 years, 8 months ago by nektarios
Modified:
3 years, 8 months ago
CC:
aboxhall+watch_chromium.org, alemate+watch_chromium.org, arv+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dbeam+watch-closure_chromium.org, dmazzoni+watch_chromium.org, dougt+watch_chromium.org, dtseng+watch_chromium.org, extensions-reviews_chromium.org, jam, je_julie, jlklein+watch-closure_chromium.org, mac-reviews_chromium.org, mlamouri+watch-content_chromium.org, nektar+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Implemented ARIA colindex, rowindex, colcount and rowcount for Chromevox. BUG=644766 R=dmazzoni@chromium.org, dtseng@chromium.org, michaelpg@chromium.org TESTED=automation API test, manually with ChromeVox CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2799443002 Cr-Commit-Position: refs/heads/master@{#466392} Committed: https://chromium.googlesource.com/chromium/src/+/55485479d83ebbdace3c7c60e463142931f4d6c5

Patch Set 1 #

Patch Set 2 : Fixed automation test. #

Total comments: 7

Patch Set 3 : Addressed comments. #

Patch Set 4 : Implemented aria row and column count. #

Patch Set 5 : Fixed conflict. #

Patch Set 6 : Added braces. #

Total comments: 2

Patch Set 7 : Fixed Blink tests. #

Patch Set 8 : Fixed Blink test expectation. #

Patch Set 9 : Fixed Blink test.# with '#' will be ignored, and an empty message aborts the commit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -63 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 2 3 4 2 chunks +11 lines, -5 lines 0 comments Download
M chrome/common/extensions/api/automation.idl View 1 2 3 4 1 chunk +18 lines, -4 lines 0 comments Download
M chrome/renderer/resources/extensions/automation/automation_node.js View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/sites/attributes.html View 1 2 3 4 1 chunk +9 lines, -8 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/attributes.js View 1 2 3 4 2 chunks +21 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 3 4 5 4 chunks +11 lines, -7 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 2 3 4 2 chunks +6 lines, -4 lines 0 comments Download
M content/test/data/accessibility/aria/aria-col-attr.html View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/aria/aria-col-attr-expected-blink.txt View 1 2 3 4 5 6 7 8 1 chunk +8 lines, -8 lines 0 comments Download
M content/test/data/accessibility/aria/aria-row-attr.html View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-row-attr-expected-blink.txt View 1 2 3 4 5 6 7 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/closure_compiler/externs/automation.js View 1 2 chunks +32 lines, -4 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M ui/accessibility/ax_node_data.cc View 1 2 3 4 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 41 (25 generated)
nektarios
3 years, 8 months ago (2017-04-04 16:51:07 UTC) #1
nektarios
@michaelpg Please review changes to externs for the Closure compiler.
3 years, 8 months ago (2017-04-05 19:32:07 UTC) #5
michaelpg
closure lgtm https://codereview.chromium.org/2799443002/diff/20001/chrome/common/extensions/api/automation.idl File chrome/common/extensions/api/automation.idl (right): https://codereview.chromium.org/2799443002/diff/20001/chrome/common/extensions/api/automation.idl#newcode571 chrome/common/extensions/api/automation.idl:571: // The zero-based index of the column ...
3 years, 8 months ago (2017-04-06 14:52:05 UTC) #6
dmazzoni
lgtm Might be best if David reviews cvox2/background/output.js, but everything else looks great https://codereview.chromium.org/2799443002/diff/20001/content/renderer/accessibility/blink_ax_tree_source.cc File ...
3 years, 8 months ago (2017-04-11 02:57:38 UTC) #8
David Tseng
https://codereview.chromium.org/2799443002/diff/20001/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js File chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js (right): https://codereview.chromium.org/2799443002/diff/20001/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js#newcode430 chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:430: enter: '@cell_summary($if($ariaCellRowIndex, $ariaCellRowIndex,' + Is the aria row index ...
3 years, 8 months ago (2017-04-11 03:40:55 UTC) #9
David Tseng
https://codereview.chromium.org/2799443002/diff/20001/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js File chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js (left): https://codereview.chromium.org/2799443002/diff/20001/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js#oldcode429 chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:429: cell: { Also, I think you also want to ...
3 years, 8 months ago (2017-04-11 03:48:09 UTC) #10
chromium-reviews
@David Your comments have been addressed. -- You received this message because you are subscribed ...
3 years, 8 months ago (2017-04-20 19:30:58 UTC) #11
David Tseng
https://codereview.chromium.org/2799443002/diff/100001/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js File chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js (right): https://codereview.chromium.org/2799443002/diff/100001/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js#newcode436 chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:436: '$if($ariaCellColumnIndex, $ariaCellColumnIndex, ' + Look at the way tableCellRowIndex/tableCellColumnIndex ...
3 years, 8 months ago (2017-04-20 23:32:40 UTC) #21
David Tseng
https://codereview.chromium.org/2799443002/diff/100001/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js File chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js (left): https://codereview.chromium.org/2799443002/diff/100001/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js#oldcode1257 chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:1257: } else if (token == 'tableCellRowIndex' || Add checks ...
3 years, 8 months ago (2017-04-20 23:38:58 UTC) #22
chromium-reviews
On 4/20/2017 7:38 PM, dtseng@chromium.org wrote: > > https://codereview.chromium.org/2799443002/diff/100001/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js > File > chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js > (left): ...
3 years, 8 months ago (2017-04-21 14:06:47 UTC) #23
David Tseng
'Nektarios Paisios' via Chromium-reviews writes: > On 4/20/2017 7:38 PM, dtseng@chromium.org wrote: >> >> https://codereview.chromium.org/2799443002/diff/100001/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js ...
3 years, 8 months ago (2017-04-21 15:29:36 UTC) #26
David Tseng
lgtm
3 years, 8 months ago (2017-04-21 15:31:48 UTC) #27
dmazzoni
I think the purpose of these attributes is to express human-readable ordinals, not indices. So ...
3 years, 8 months ago (2017-04-21 15:44:06 UTC) #30
chromium-reviews
Thanks for the reply. Note that I did lgtm the cl (at the top of ...
3 years, 8 months ago (2017-04-21 15:52:17 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799443002/160001
3 years, 8 months ago (2017-04-21 17:05:00 UTC) #38
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 18:11:09 UTC) #41
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/55485479d83ebbdace3c7c60e463...

Powered by Google App Engine
This is Rietveld 408576698